remove duplicate implicit_optional = True line in setup.cfg#1791
remove duplicate implicit_optional = True line in setup.cfg#1791bouweandela merged 1 commit intomainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1791 +/- ##
==========================================
+ Coverage 91.11% 91.50% +0.39%
==========================================
Files 203 202 -1
Lines 10906 10904 -2
==========================================
+ Hits 9937 9978 +41
+ Misses 969 926 -43
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
zklaus
left a comment
There was a problem hiding this comment.
I see we are keeping the reverse alphabetical ordering.
|
agh! @bouweandela how do you shut up cov - the line's complaining about is ye olde, and saw that in your PR that just got merged too, but thought it'd keep quiet after merge |
that good or bad? 😁 |
|
Alphabetical is nicer, but let's get this merged. I have no idea what codecov is thinking here.. |
|
I thought you were the cov whisperer Bouwe 😆 |
|
Thinking about it: the coverage change from #1769 is probably getting picked up because no coverage report was uploaded when that was merged into main because the tests failed on CircleCI. |
|
bingo 💡 That's it, man! |
Description
Thanks @zklaus for noticing this 🍺
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: