Modernize tests for esmvalcore.preprocessor.save

[bouweandela]

Description

This modernizes the unit tests for esmvalcore.preprocessor.save and adds an extra test that the parent directory of the target file is created if it does not exist.

Part of #1609.

---

Before you get started

• ☝ Create an issue to discuss what you are going to do

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

• 🧪 The new functionality is relevant and scientifically sound
• 🛠 This pull request has a descriptive title and labels
• 🛠 Code is written according to the code quality guidelines
• 🛠 Unit tests have been added
• 🛠 Changes are backward compatible
• 🛠 The list of authors is up to date
• 🛠 All checks below this pull request were successful

---

To help with the number pull requests:

• 🙏 We kindly ask you to review two other open pull requests in this repository

[codecov]

Codecov Report

Merging #1799 (8ad58df) into main (4d48ece) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1799   +/-   ##
=======================================
  Coverage   91.51%   91.51%           
=======================================
  Files         202      202           
  Lines       10908    10908           
=======================================
  Hits         9982     9982           
  Misses        926      926           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[valeriupredoi]

cheers @bouweandela - wouldn't it even better to make those tests individual functions outside the overarching test class? Either way - modern now 😁

[bouweandela]

wouldn't it even better to make those tests individual functions outside the overarching test class?

Yes, but it would make the diff much bigger. Anyway, I can do another commit to change it if you want?

[bouweandela]

@valeriupredoi I removed the overarching class. Could you have another look please?

[valeriupredoi]

lovely! I think the extra work is worth it, cheers, bud 🍺

[bouweandela]

@ESMValGroup/technical-lead-development-team Could someone please do a final check and merge?

[schlunma]

Thanks @bouweandela @valeriupredoi 🚀