Import from esmvalcore.config in the esmvalcore.experimental module#1816
Merged
valeriupredoi merged 1 commit intomainfrom Nov 22, 2022
Merged
Import from esmvalcore.config in the esmvalcore.experimental module#1816valeriupredoi merged 1 commit intomainfrom
esmvalcore.config in the esmvalcore.experimental module#1816valeriupredoi merged 1 commit intomainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1816 +/- ##
==========================================
- Coverage 91.49% 91.49% -0.01%
==========================================
Files 202 202
Lines 10908 10907 -1
==========================================
- Hits 9980 9979 -1
Misses 928 928
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
schlunma
approved these changes
Nov 22, 2022
Contributor
schlunma
left a comment
schlunma
left a comment
There was a problem hiding this comment.
Works as expected, thanks Bouwe!
Member
Author
|
@ESMValGroup/technical-lead-development-team Would anyone have time for a final check and merge please? |
Contributor
|
cheers @bouweandela and @schlunma 🍺 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When importing
esmvalcore.experimental, a deprecation warning fromesmvalcore.experimental.configis shown because the configuration is still imported from the old place. Importing from the newesmvalcore.configmodule avoids the warning.Closes #1815
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: