Improve error handling if an esgf index node is offline#1834
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1834 +/- ##
=======================================
Coverage 91.52% 91.53%
=======================================
Files 203 203
Lines 10920 10921 +1
=======================================
+ Hits 9995 9996 +1
Misses 925 925
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Contributor
|
looking at this now, bud 👍 |
valeriupredoi
approved these changes
Nov 29, 2022
Contributor
valeriupredoi
left a comment
valeriupredoi
left a comment
There was a problem hiding this comment.
this is the way I should have fixed it yesterday! I was not aware that the node issue would actually impact a run until today, when I wanted to test the install procedure in the other PR. Good work, man! Let's get this in asap 🍺
2 tasks
This was referenced Dec 2, 2022
bouweandela
pushed a commit
that referenced
this pull request
Dec 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This enables the graceful handling of more types of failure to connect to an esgf index node.
Closes #1833
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: