Removed unnecessary test that fails with iris 3.4.0#1846
Merged
valeriupredoi merged 2 commits intomainfrom Dec 2, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1846 +/- ##
=======================================
Coverage 91.54% 91.54%
=======================================
Files 203 203
Lines 10945 10945
=======================================
Hits 10020 10020
Misses 925 925 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Contributor
Author
|
The test coverage will be restored when fixing #1802 (but we need an |
bouweandela
reviewed
Dec 2, 2022
bouweandela
approved these changes
Dec 2, 2022
Member
bouweandela
left a comment
There was a problem hiding this comment.
Thanks for taking care of this!
valeriupredoi
approved these changes
Dec 2, 2022
Contributor
valeriupredoi
left a comment
There was a problem hiding this comment.
thanks a lot, Manu! 🍺
This was referenced Dec 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes a test that fails after a bugfix that has been introduced with iris 3.4.0 (SciTools/iris#5062). The tests that check that
dtypeis preserved are now located in iris and can be removed from our test suite.Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: