Updated URL of ICON grid file used for testing#1914
Merged
bouweandela merged 2 commits intomainfrom Feb 3, 2023
Merged
Conversation
15 tasks
Codecov Report
@@ Coverage Diff @@
## main #1914 +/- ##
=======================================
Coverage 92.10% 92.11%
=======================================
Files 234 234
Lines 12133 12133
=======================================
+ Hits 11175 11176 +1
+ Misses 958 957 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
remi-kazeroni
approved these changes
Feb 2, 2023
Contributor
remi-kazeroni
left a comment
remi-kazeroni
left a comment
There was a problem hiding this comment.
Looks good to me, thanks @schlunma!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In #1664, I had to update the ICON grid file used for testing. To test the automatic download of this file, I temporarily uploaded it to a cloud service and used this URL for testing. Since #1664 is merged now and the new grid file is publicly available on GitHub, this temporary URL to the cloud service can be replaced with the URL to the file on GitHub.
This also affects the three ICON netCDF test files, where the URL is stored as a global attribute.
Related to #1664
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: