-
Notifications
You must be signed in to change notification settings - Fork 44
Add preliminary CMIP7 support #2935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Allow use of branding_suffix in other projects than CMIP7 to select the right variable from the CMOR table
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2935 +/- ##
==========================================
- Coverage 95.59% 95.59% -0.01%
==========================================
Files 266 266
Lines 15573 15593 +20
==========================================
+ Hits 14887 14906 +19
- Misses 686 687 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
use official drs update docstrings
| "rcm_version", | ||
| "driver", | ||
| "domain", | ||
| "activity", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The activity is uniquely determined by the exp facet, so this only adds noise and no new information. To keep it readable, I would propose to remove this.
Description
Makes a start with #2874. Support for downloading from ESGF has not been implemented yet as no CMIP7 data has been published to ESGF yet. The first CMIP7 data is expected sometime in the next few months.
Works with examples/recipe_python.yml and
tasdata created with Simple_recmorise_cmip6-cmip7.ipynb after some updates to that notebook: Simple_recmorise_cmip6-cmip7.ipynbExample
datasetsrecipe entry:A copy of
examples/recipe_python.ymlwith the fake CMIP7 dataset generated by the notebook is available under Details.Details
activityandinstituteare automatically added from theCMIP6_CV.jsonfile for CMIP6, but for CMIP7 this file does not appear to be available yet. I found ESGF/esgf-vocab#150 (comment) describing some initial work to generate it from the controlled vocabulary.Link to documentation:
Backward incompatible change
It is no longer possible to pass
deriveas a positional argument to theget_variablemethod. Please usederive=Trueorderive=Falseinstead ofTrueorFalserespectively. Similarly,frequencyandcheck_levelare now keyword only arguments for the functionscmor_check_metadata,cmor_check_data, andcmor_check.Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
Changes are backward compatibleTo help with the number pull requests: