Skip to content

Add a method to save citation information#402

Merged
bouweandela merged 108 commits intomasterfrom
save_citation
Mar 31, 2020
Merged

Add a method to save citation information#402
bouweandela merged 108 commits intomasterfrom
save_citation

Conversation

@SarahAlidoost
Copy link
Member

@SarahAlidoost SarahAlidoost commented Dec 17, 2019

Before you start, please read CONTRIBUTING.md.

Tasks

  • Create an issue to discuss what you are going to do, if you haven't done so already (and add the link at the bottom)
  • This pull request has a descriptive title that can be used in a changelog
  • Add unit tests
  • Public functions should have a numpy-style docstring so they appear properly in the API documentation. For all other functions a one line docstring is sufficient.
  • If writing a new/modified preprocessor function, please update the documentation
  • Circle/CI tests pass. Status can be seen below your pull request. If the tests are failing, click the link to find out why.
  • Codacy code quality checks pass. Status can be seen below your pull request. If there is an error, click the link to find out why. If you suspect Codacy may be wrong, please ask by commenting.
  • Please use yamllint to check that your YAML files do not contain mistakes
  • If you make backward incompatible changes, make a new pull request in the ESMValTool repository and add the link below

Link to corresponding ESMValTool pull request ESMValGroup/ESMValTool#1545

If you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.


Closes #91

@mattiarighi mattiarighi added the enhancement New feature or request label Dec 19, 2019
@bouweandela bouweandela changed the base branch from development to master January 3, 2020 12:39
Copy link
Member

@bouweandela bouweandela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the improvements! I added a few more comments.

Copy link
Member

@bouweandela bouweandela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattiarighi Could you please test? It would be good if you could also check if the runtime of a recipe with lots of input data, like perfmetrics, is not affected too badly.

@bouweandela
Copy link
Member

We should probably also make a new release for this.

@bouweandela bouweandela mentioned this pull request Mar 30, 2020
4 tasks
@mattiarighi
Copy link
Contributor

recipe_permetrics_CMIP5.yml runtimes:

  • in master: [25:36.240417, 27:53.705252, 27:59.009339, 25:46.094682, 25:23.925156]; median = 25:46.094682.
  • in save_citation: [25:40.530607, 25:36.464112, 26:06.032161, 25:30.391732, 25:20.122022]; median = 25:36.464112.

No difference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

For each figure, provide citation information in a standard format

4 participants