Skip to content

Consistently use dimension/coordinate names in VariableInfo.coordinates #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bouweandela merged 2 commits into from
Jan 10, 2020
Merged

Consistently use dimension/coordinate names in VariableInfo.coordinates #413

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d12b51
Use coordinate names instead of axis
bouweandela Dec 23, 2019
211a3d0
Improve docstring
bouweandela Dec 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions esmvalcore/cmor/table.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,11 +164,7 @@ def _assign_dimensions(self, var, generic_levels):
)
raise

axis = coord.axis
if not axis:
axis = 'none'

var.coordinates[axis] = coord
var.coordinates[dimension] = coord

def _load_coordinates(self):
self.coords = {}
Expand Down Expand Up @@ -392,7 +388,11 @@ def __init__(self, table_type, short_name):
self.dimensions = []
"""List of dimensions"""
self.coordinates = {}
"""Coordinates"""
"""Coordinates

This is a dict with the names of the dimensions as keys and
CoordinateInfo objects as values.
"""

self._json_data = None

Expand Down