-
Notifications
You must be signed in to change notification settings - Fork 45
Apply select preprocessor to area, volume and zonal statistics fx variables and add use of fx_files as list of dictionaries #439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
81 commits
Select commit
Hold shift + click to select a range
7d19611
routine to preprocess fx variables
valeriupredoi 01afa17
fixed bug
valeriupredoi a96cae1
added opt arg
valeriupredoi ab887ef
added non functional test
valeriupredoi 615ab3b
pick up already preprocced files as input
valeriupredoi f9c0047
made all fx vars run as ancestors
valeriupredoi 2b575e1
fixed handling of tasks
valeriupredoi 434ee12
fixed test
valeriupredoi d1cdbc6
fixed main var bug finally
valeriupredoi 1ba5c74
fixed test proper
valeriupredoi 2ae17bc
removed old flag
valeriupredoi 7bb133d
added extra preproc sugg by Lee
valeriupredoi e99aff0
added extra preproc step sugg by Lee
valeriupredoi aa67226
added check on ancestry
valeriupredoi 590e494
Merge branch 'preprocess_fx_variables' of https://github.com/ESMValGr…
valeriupredoi d897b1b
made it more robust
valeriupredoi c1e5141
correct profile applied
valeriupredoi 5fc532f
replaced to dummy var
valeriupredoi 9ed2f57
made it more robust
valeriupredoi f84f6e7
more power to the test
valeriupredoi e520166
allow for user defined fxvars dicts
valeriupredoi 967423f
added needed tests for fxvars dicts
valeriupredoi e8711a2
added doc on new features for fx files
valeriupredoi a3b33dd
remove time preprocessors for fx mips
valeriupredoi aaa638f
added time preprocessors list
valeriupredoi c80d027
fixed test and asdded check on time preproc removal
valeriupredoi dbcd03e
changed declaration of fx files
valeriupredoi fe5a1ea
add raiser if no available fx vars
valeriupredoi e0ab9cb
actually use the recipe error correctly
valeriupredoi c6e4ca3
adding Lee's suggestion
valeriupredoi 0750802
adding Lee's suggestion
valeriupredoi a4ff5fc
correct line too long
valeriupredoi 15e1a67
added Manuel suggestion
valeriupredoi cba0cbb
removed redundant checks
valeriupredoi a733e0d
simplified approach and include activity
valeriupredoi 44aa6ae
removed redundant test
valeriupredoi 2a603cb
remove duplication in task ancestry and run task only once for unique…
valeriupredoi 4c0f8be
use the preproc time preprocs list and robustify the testing as a con…
valeriupredoi a22a8fa
renamed tests and added extra case for activity switch
valeriupredoi 16f8fd6
shuffled section at Monsegnor Mattia indication
valeriupredoi bd1a0ac
added note on running preproc steps on various time and non time fx vars
valeriupredoi 68fb173
added to API
valeriupredoi 1a6b551
added to API
valeriupredoi 1a2bb90
fixed linter
valeriupredoi ef70bb3
removed check on OBS mips
valeriupredoi 5460f44
made the preproccing of fx vars in preproc step default and always on
valeriupredoi aec6cad
removed redundant fx)var_preprocess flag
valeriupredoi e070f71
changed doc to remove pointers to defunct fx_var_preprocess flag
valeriupredoi c535aab
actual correct setter for fx files preproc
valeriupredoi f152ed4
actually fixed now
valeriupredoi af10679
Fixed prospector issues
schlunma 13cf2b1
Small optimizations in fx file retrieval
schlunma 2b46632
Expanded unit tests
schlunma c4877dd
Fixed docstrings
schlunma 1001754
Added two more tests
schlunma 99c2aae
fixed test
valeriupredoi 147b151
slight docstring mod
valeriupredoi b4ccec4
slight docstring mod
valeriupredoi 87931ba
fixed the last duplicate preproc file error reported by Lee, test wil…
valeriupredoi f827ce5
removed print statement
valeriupredoi b8aa4d9
overhauled method for identical ancestry removal
valeriupredoi 8f97597
started work on the extra test
valeriupredoi 3ed2dc7
bumped priority of clean task
valeriupredoi da7bbbb
completed test
valeriupredoi 8a854a6
fixed bug related to single product duplicity
valeriupredoi 431e02d
added inline comments
valeriupredoi ae128e2
tast now works at any time
valeriupredoi fc8d3bb
Merge branch 'master' into preprocess_fx_variables
valeriupredoi 5c0c7fe
Merge branch 'master' into preprocess_fx_variables
valeriupredoi 39a34b5
fixed case when there are no tasks at all
valeriupredoi 8c90798
fixed crass bug noticed by Lee
valeriupredoi 3b95671
Merge branch 'master' into preprocess_fx_variables
valeriupredoi 18cb3f6
priority ordering of tasks based on importance wrt ancestry
valeriupredoi b80e47e
rejiggled priorities since the sorting is done not in reverse order
valeriupredoi b129407
fixed major fx file generation bug
valeriupredoi d3548d6
special case for fx favrs
valeriupredoi 0da1ea4
fixed test in light of changes
valeriupredoi dbe3c17
Merge branch 'master' into preprocess_fx_variables
valeriupredoi f361395
Merge branch 'master' into preprocess_fx_variables
valeriupredoi 5f49f22
Merge branch 'master' into preprocess_fx_variables
valeriupredoi dc30150
Merge branch 'master' into preprocess_fx_variables
valeriupredoi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.