Moved and completed time preprocessors list (PR 439 child 1)#508
Merged
valeriupredoi merged 2 commits intomasterfrom Feb 21, 2020
Merged
Moved and completed time preprocessors list (PR 439 child 1)#508valeriupredoi merged 2 commits intomasterfrom
valeriupredoi merged 2 commits intomasterfrom
Conversation
Contributor
Author
|
hey guys @bouweandela @schlunma @zklaus can I get a quick approval on this one so I can merge in master and go on producing #439 children pls? 🍺 |
zklaus
approved these changes
Feb 21, 2020
|
PS: It would have been helpful to have a sentence in the PR description on what this is trying to achieve. I was able to deduce it from the code only because it was so small and well-written. |
Contributor
Author
|
cheers boss! 🍺 |
Contributor
Author
|
I will add plenty of info to the other ones, gimme a sec, merge this in the next now 🚜 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before you start, please read CONTRIBUTING.md.
Tasks
yamllintto check that your YAML files do not contain mistakesIf you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.
This alleviates some of the burden from PR #439 that will be now be broken into smaller bits - this is the first child