Updated docstrings for area and volume statistics to work with fx variables definitions (PR 439 child 3)#509
Closed
valeriupredoi wants to merge 2 commits intomasterfrom
Closed
Updated docstrings for area and volume statistics to work with fx variables definitions (PR 439 child 3)#509valeriupredoi wants to merge 2 commits intomasterfrom
valeriupredoi wants to merge 2 commits intomasterfrom
Conversation
zklaus
reviewed
Feb 21, 2020
zklaus
left a comment
There was a problem hiding this comment.
Looks ok, but is this linked to code changes as well? I think this update might need to go together with the corresponding code changes or at least be linked with the relevant PR so that we can check that the description reflects the behaviour.
Contributor
Author
|
yes, we should not merge now, lemme just create the order in which the three PRs should be examined and merged. Gimme a sec, will tag you in one moment 🍺 |
Contributor
|
I believe we can close this since #999 got merged, can't we? |
|
Agreed. #999 removed the parameters whose documentation is improved here. Closing. @valeriupredoi please reopen if you disagree. |
Member
|
Deleted the branch to keep the repo tidy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before you start, please read CONTRIBUTING.md.
Tasks
yamllintto check that your YAML files do not contain mistakesIf you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.
READ BEFORE PROCEEDING
Issue #436 lays down the need for preprocessing fx variables as integrated with
area_atatisticsandvolume_statistics; PR #439 implements that; reviewers expressed their consternation that that PR is huuuge so it got broken down; the layout for the PR 439 children is outlined in #436 (comment)This is the 3rd child that depends upon integration of the 2nd child; it contains the updated docstrings for area and volume statistics in light of the new recipe syntax with fx vars as dicts.