Add Listing and finding recipes to the experimental notebook API#901
Merged
nielsdrost merged 19 commits intomasterfrom Dec 16, 2020
Merged
Add Listing and finding recipes to the experimental notebook API#901nielsdrost merged 19 commits intomasterfrom
nielsdrost merged 19 commits intomasterfrom
Conversation
pybtex is a bibtex parser / renderer for python (https://pybtex.org/)
4 tasks
RecipeList is a container for recipes.
Because maintainers are also defined as authors in config-references.yml, rename class Author -> Contributor
Contributor
Author
|
Hi @nielsdrost , this one is ready for review! |
nielsdrost
reviewed
Dec 16, 2020
Member
nielsdrost
left a comment
There was a problem hiding this comment.
Nice work @stefsmeets! Works like a charm (after the bibtex fixes got merged)
There seem to be a few Codacy issues related to imports, could you have a look?
| string += '\n\n' | ||
| string += f'{self.description}' | ||
|
|
||
| string += '\n\n### Contributors' |
Member
There was a problem hiding this comment.
I think this should be authors, and mainainters is perhaps missing.
Contributor
Author
There was a problem hiding this comment.
Yep, good point! I added the maintaners and fixed the string.
Co-authored-by: Niels Drost <n.drost@esciencecenter.nl>
Contributor
Author
Yep:
|
nielsdrost
approved these changes
Dec 16, 2020
Member
nielsdrost
left a comment
There was a problem hiding this comment.
Thank @stefsmeets, looks great!
10 tasks
This was referenced Jan 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi all, this code implements some new functionality for the experimental API we are building. It introduces some functions to list recipes, find recipes using some search patterns, and display nicely formatted recipe metadata in a jupyter notebook.
Tasks
If you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.
Follows up on #868
For more discussion, see issue #498
Documentation: https://esmvaltool--901.org.readthedocs.build/projects/ESMValCore/en/901/api/esmvalcore.api.html
Demo notebook: https://gist.github.com/stefsmeets/f4b7fc7fffe78cecb895b12bfb8ea671