Set the version number on the development branches to one minor version more than the last release #2964
Conversation
|
Tests are failing due to #2965 |
|
@bouweandela would you mind turning the GA Test (just the test flow should do) on pls? And don't merge |
|
Maybe it's easiest of you run the tests yourself because you know what you want from this. Would that be OK with you? You could just create a new branch off this branch if you would like to use the changes in this one. |
|
aye, will do, man. Got some ideas before that anyway, steady as she goes for now |
|
@bouweandela now that I figured out the shapely issue, and it's got nothing to do with scm or versioning, I think we can release this into the wild; if you make it RFR then I can review it and get it out. One thing though - can we maybe change the pin of |
Would it make sense to create a separate issue to explain what the issue is? It seems unrelated to this pull request. |
|
yeah I opened #2971 - but am rather dubious about it since I noticed it only on my laptop (yeh, running an OK Ubuntu not 19th century 😆 ) |
valeriupredoi
left a comment
There was a problem hiding this comment.
easiest PR I've reviewed in months 😆
|
@ESMValGroup/technical-lead-development-team Could someone please do a final check and merge? |
|
I am a changed person in 2023 so I qualify to do the last checks and merge 🤣 (seriously now, I'm grabbing this in so we don't have to wait any more, if there are any issues, better find them earlier) |
Description
This uses the next minor release as the development version. E.g. because we are currently developing v2.8, this sets the version number of development branches so it starts with
v2.8.0-dev. See setuptool-scm for more detailed information.Related to ESMValGroup/ESMValCore#1854.
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number of pull requests: