Update project metadata (readme, license, setup.py, etc)#11
Merged
bouweandela merged 18 commits intomasterfrom Dec 1, 2020
Merged
Update project metadata (readme, license, setup.py, etc)#11bouweandela merged 18 commits intomasterfrom
bouweandela merged 18 commits intomasterfrom
Conversation
11 tasks
11 tasks
stefsmeets
requested review from
bouweandela and
nielsdrost
and removed request for
nielsdrost
bouweandela
reviewed
Nov 27, 2020
Member
bouweandela
left a comment
bouweandela
left a comment
There was a problem hiding this comment.
Looks good, just some suggestions for clarifying the text.
Co-authored-by: Bouwe Andela <b.andela@esciencecenter.nl>
Co-authored-by: Bouwe Andela <b.andela@esciencecenter.nl>
Contributor
Author
|
Hi @bouweandela , I addressed your comments! I believe this is ready to merge! |
bouweandela
reviewed
Dec 1, 2020
bouweandela
changed the title
bouweandela
approved these changes
Dec 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The other PR (#8) became a bit of a mess, so I'm continuing here.
setup.py