Add functions to import the datasets#3
Merged
stefsmeets merged 20 commits intomasterfrom Nov 19, 2020
Merged
Conversation
i.e. `tracking_id, history and creation_date attributes inconsistent`
Contributor
Author
|
I have some issues with the dataset: |
27 tasks
11 tasks
bouweandela
reviewed
Nov 9, 2020
Co-authored-by: Bouwe Andela <b.andela@esciencecenter.nl>
bouweandela
reviewed
Nov 9, 2020
bouweandela
reviewed
Nov 9, 2020
bouweandela
reviewed
Nov 9, 2020
bouweandela
reviewed
Nov 9, 2020
bouweandela
reviewed
Nov 9, 2020
bouweandela
reviewed
Nov 9, 2020
Contributor
Author
|
Two more datasets give warnings: |
Member
If they don't work, just delete the files and add them to the ignore list in datasets.yml so they will not be downloaded again. |
Contributor
Author
|
This is ready to be merged for all I'm concerned. @nielsdrost could you have a look? |
nielsdrost
approved these changes
Nov 18, 2020
Member
nielsdrost
left a comment
There was a problem hiding this comment.
Looks good to me!
I also tried it out. Package seems to work just fine :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR I set up the basic setup.py, and add some functionality to load the timeseries data.
Needed for ESMValGroup/ESMValCore#856