Skip to content

Add functions to import the datasets#3

Merged
stefsmeets merged 20 commits intomasterfrom
make_package
Nov 19, 2020
Merged

Add functions to import the datasets#3
stefsmeets merged 20 commits intomasterfrom
make_package

Conversation

@stefsmeets
Copy link
Contributor

@stefsmeets stefsmeets commented Nov 3, 2020

In this PR I set up the basic setup.py, and add some functionality to load the timeseries data.

from esmvaltool_sample_data import load_timeseries_data
cubelist = load_timeseries_data()

Needed for ESMValGroup/ESMValCore#856

@stefsmeets stefsmeets self-assigned this Nov 3, 2020
i.e. `tracking_id, history and creation_date attributes inconsistent`
@stefsmeets
Copy link
Contributor Author

I have some issues with the dataset:
CMIP6.CMIP.FIO-QLNM.FIO-ESM-2-0.historical.r1i1p1f1.Amon.ta.gn.v20191204
which raises
ValueError: Cube 'air_temperature' must contain a single 1D y coordinate.

@stefsmeets stefsmeets marked this pull request as ready for review November 6, 2020 13:45
Co-authored-by: Bouwe Andela <b.andela@esciencecenter.nl>
@stefsmeets
Copy link
Contributor Author

stefsmeets commented Nov 10, 2020

Two more datasets give warnings:

esmvaltool_sample_data/data/timeseries/CMIP6/CMIP/NCAR/CESM2-WACCM-FV2/historical/r1i1p1f1/Amon/ta/gn/v20191120
/home/stef/miniconda3/envs/esmvaltool/lib/python3.8/site-packages/iris/fileformats/_pyke_rules/compiled_krb/fc_rules_cf_fc.py:2290: UserWarning: Gracefully filling 'lat' dimension coordinate masked points
  warnings.warn(msg.format(str(cf_coord_var.cf_name)))
/home/stef/miniconda3/envs/esmvaltool/lib/python3.8/site-packages/iris/fileformats/_pyke_rules/compiled_krb/fc_rules_cf_fc.py:2290: UserWarning: Gracefully filling 'lat' dimension coordinate masked points
  warnings.warn(msg.format(str(cf_coord_var.cf_name)))
esmvaltool_sample_data/data/timeseries/CMIP6/CMIP/NCAR/CESM2-FV2/historical/r1i1p1f1/Amon/ta/gn/v20191120
/home/stef/miniconda3/envs/esmvaltool/lib/python3.8/site-packages/iris/fileformats/_pyke_rules/compiled_krb/fc_rules_cf_fc.py:2290: UserWarning: Gracefully filling 'lat' dimension coordinate masked points
  warnings.warn(msg.format(str(cf_coord_var.cf_name)))
/home/stef/miniconda3/envs/esmvaltool/lib/python3.8/site-packages/iris/fileformats/_pyke_rules/compiled_krb/fc_rules_cf_fc.py:2290: UserWarning: Gracefully filling 'lat' dimension coordinate masked points
  warnings.warn(msg.format(str(cf_coord_var.cf_name)))

@bouweandela
Copy link
Member

Two more datasets give warnings:

If they don't work, just delete the files and add them to the ignore list in datasets.yml so they will not be downloaded again.

@stefsmeets
Copy link
Contributor Author

This is ready to be merged for all I'm concerned. @nielsdrost could you have a look?
I will address problems with the setup.py in a separate PR (metadata etc.).

Copy link
Member

@nielsdrost nielsdrost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

I also tried it out. Package seems to work just fine :-)

@stefsmeets stefsmeets merged commit b0b5b6d into master Nov 19, 2020
@stefsmeets stefsmeets deleted the make_package branch November 19, 2020 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants