Move download script to root directory#9
Conversation
|
I tried to run this script but ran into some trouble.
Then I gave up for today ;-) |
Thanks @nielsdrost , good points and it seems like I should have tested this myself first 😅 |
|
The |
bouweandela
left a comment
There was a problem hiding this comment.
The download script and its configuration file (datsets.yml) belong together, so if you're moving one to the top level, I would also move the other to the top level.
|
Hi @bouweandela , can you have another look? I think this is ready to merge! |
bouweandela
left a comment
There was a problem hiding this comment.
Thanks for making the changes, I tried to run the script but it failed on loading the configuration file. I also noticed that the documentation on how run the script in CONTRIBUTING.md has not been updated yet.
Yeah, my bad for not testing if it worked. Should be good now 👍 |
This PR moves the download script to the root directory and gives it a more logical name.