Feature updates: DataTable, user management, events, and UI fixes by Alpha871 · Pull Request #16 · ESNcz/ers

Alpha871 · 2026-03-27T19:08:54Z

Summary

Migrate tables to TanStack Table with reusable DataTable component
Add PATCH /users/:id endpoint for admins to edit user information
Add priorityListDeadline field to events
Add remove role functionality
Fix sugar cubes visibility for registered participants and admins
Add Terms & Conditions, Code of Conduct, Photo Consent links to event edit modal
Fix frontend API domain for SSR in Docker
Set organization legalName on initialise

Test plan

Verify DataTable renders correctly on all management pages
Test admin user editing via /manage-people
Test priorityListDeadline on event creation and editing
Test role removal functionality
Verify sugar cubes button visibility

… fixes - Migrate tables to TanStack Table with reusable DataTable component - Add PATCH /users/:id endpoint for admins to edit user information - Add priorityListDeadline field to events - Add remove role functionality - Fix sugar cubes visibility for registered participants and admins - Add Terms & Conditions, Code of Conduct, Photo Consent links to event edit modal - Fix frontend API domain for SSR in Docker - Set organization legalName on initialise

slabys · 2026-03-28T20:06:15Z

backend/database/migrations/1769500000000-event-priority-list-deadline.ts

@@ -0,0 +1,15 @@
+import { MigrationInterface, QueryRunner } from "typeorm";
+
+export class EventPriorityListDeadline1769500000000 implements MigrationInterface {


How was this migrations created?

Also this migration is missing the updated enum for role permissions.

Use Nestjs migration:generate by pnpm migration:generate ./database/migration/<migration_name>

alright I will use pnpm migration:generate

slabys · 2026-03-28T20:09:27Z

compose.yml

@@ -88,6 +89,7 @@ services:
    environment:
      - NEXT_PUBLIC_WEB_DOMAIN=${WEB_DOMAIN:-localhost:3000}
      - NEXT_PUBLIC_API_DOMAIN=${API_DOMAIN:-localhost:4000}
+      - API_DOMAIN=http://backend:4000


Why adding API_DOMAIN to frontend, when NEXT_PUBLIC_API_DOMAIN is available?

This value also should be configurable by .env not directly set inside docker compose.

I had some trouble when building the docker image adding this to be able to run it

slabys · 2026-03-28T20:10:53Z

docker-compose.yml

@@ -1 +1 @@
 name: ers


Why was compose.yml renamed to docker-compose.yml?

I will keep the same

slabys · 2026-03-28T20:11:12Z

frontend/src/proxy.ts

 ];

-const apiUrl = process.env.NEXT_PUBLIC_API_DOMAIN;
+const apiUrl = process.env.API_DOMAIN || process.env.NEXT_PUBLIC_API_DOMAIN;


NEXT_PUBLIC_API_DOMAIN and API_DOMAIN are technically the same value.

More in docker-compose.yml

I had trouble while run the docker image

slabys · 2026-03-28T20:11:51Z

frontend/src/.DS_Store

Do not include this file!

slabys · 2026-03-28T20:58:22Z

frontend/src/components/modals/EditUserModal/EditUserModal.tsx

+      onSuccess: () => {
+        queryClient.invalidateQueries({ queryKey: [getGetAllUsersQueryKey()] });
+        handleOnSuccess();
+        form.reset();


handleClose()

slabys · 2026-03-28T21:06:37Z

frontend/src/components/data-table/DataTable.tsx

+
+export function DataTable<TData>({
+  columns,
+  data,


Is this data prop set as "Stable" reference according to the TanStack docs?
https://tanstack.com/table/latest/docs/guide/data#give-data-a-stable-reference

Yes memoize them (data and columns)

slabys · 2026-03-28T21:10:48Z

frontend/src/app/(authorized)/sent-applications/page.tsx

+    sinceSince: now,
+  });
+
+  const ongoingEvents = useMemo(() => {


Ongoing events will be visible only on the home page.

Send application is just review of all the previous registrations send by user

slabys · 2026-03-28T21:11:10Z

frontend/src/app/(authorized)/manage-organisations/page.tsx

+    deleteOrganizationMutation,
+  );
+
+  // const rows = organisationsList?.map((organization, index) => (


Remove comment

slabys · 2026-03-28T21:18:49Z

frontend/src/utils/table-helpers.ts

This extractText is used as extractor from Short description in JSON format for RichText.

Use RichTextRenderer to render this format, which already includes this functionality. Also possible to add prop textOnly for the component or create separate component for SimpleTextRendered based on the RichTextRenderer JSON structure

slabys · 2026-03-28T21:21:01Z

@Alpha871
Code review submitted. Please review the comments and improve them with the next commit, or add comments to clarify.

- Add organization join request entity, controller, and migration - Add spot notification response DTO and email template - Add browse-organisations, my-join-requests, and organisation-join-requests pages - Add OrganisationJoinRequests component - Add application management columns for DataTable - Add event priority list deadline migration - Add pnpmrc config

…on, UI improvements - Add organization join requests (entity, controller, service methods, migration) - Add spot notification emails for assigned participants - Migrate all DataTable columns to TanStack ColumnDef[] (remove createColumns wrapper) - Memoize data/columns for stable TanStack Table references - Add RichTextRenderer textOnly prop, remove extractText helper - Add image processing: resize + webp conversion via sharp - Add user organisations column to export sheet - Add browse-organisations and my-join-requests pages - Add manage requests button on MyOrganisation page - Simplify NEXT_PUBLIC_API_DOMAIN usage - Fix tsconfig baseUrl deprecation warnings - Block priority list deadline modification after event ends - Add skipGlobalNotifications support for MutationCache - Clean up unused imports and dead code

- Use ApplicationManagementColumns with DataTable instead of raw Mantine Table - Memoize columns and data for stable TanStack Table references - Remove unused Table/ScrollArea imports

- Refactor DataTable columns (events, organisations, people, members, applications) - Simplify manage-events, manage-organisations and sent-applications pages - Update events controller and roles permissions - Replace event-priority-list-deadline migration with new timestamp - Replace docker-compose.yml with compose.yml (modern format) - Minor tweaks to proxy, customInstance, table-helpers and EditUserModal

slabys · 2026-04-04T16:08:36Z

frontend/src/utils/routes.ts


  // Organization
  ORGANISATION_MEMBERS: (props: { id: string }) => `/organisation-members/${props.id}`,
+  ORGANISATION_JOIN_REQUESTS: (props: { id: string }) => `/organisation-join-requests/${props.id}`,


Why are there 3 new routes?

It should be possible to create the workflow on existing organisation page.

slabys · 2026-04-04T16:15:43Z

frontend/src/app/(authorized)/my-join-requests/page.tsx

+  [OrganizationJoinRequestStatus.rejected]: "red",
+};
+
+const MyJoinRequestsPage = () => {


Unnecessary page.
Usually people send request only to one organisation.

They can request it on the already existing page before this comming not to create more confusing user interface

slabys · 2026-04-04T16:16:36Z

frontend/src/app/(authorized)/organisation-join-requests/[id]/page.tsx

+  params: Promise<{ id: string }>;
+}
+
+const OrganisationJoinRequestsPage = ({ params }: Props) => {


Unnecessary page. Why cannot this be on the page of the organisation for easier overview?

slabys · 2026-04-12T20:44:02Z

frontend/src/app/(authorized)/manage-events/page.tsx

-  const handleDuplicateEvent = (event: EventSimple) => {
-    duplicateEventMutation.mutate({ id: event.id });
-  };
+  const handleDuplicateEvent = useCallback(


Why do the handleDuplicateEvent and handleDeleteEvent use useCallback?

Columns must maintain stable references and track their dependencies; otherwise, updates will reset their internal state and trigger column re-creation.
tanstack.com/table/latest/docs/guide/data
https://tanstack.com/table/latest/docs/faq

if we don't want to use usecallback we can just to do this : const columns = useMemo(() => eventManagementColumns(
(event) => duplicateEventMutation.mutate({ id: event.id }),
(event) => deleteEventMutation.mutate({ eventId: event.id }),
), [duplicateEventMutation.mutate, deleteEventMutation.mutate]);

Or keep the structure of the code

slabys · 2026-04-12T20:54:54Z

backend/apps/api/src/modules/users/users.controller.ts

+	/**
+	 * Update user data by admin
+	 */
+	@ApiBadRequestResponse({ description: "Username is already taken" })


I dont think this is supposed to be the description for this EP

slabys · 2026-04-12T21:37:49Z

frontend/src/components/ManageApplicationsTable/ManageApplicationsTable.tsx

-      id: application.id,
-    });
-  };
+  const handleDeleteApplication = useCallback(


Why the use of useCallback?

slabys · 2026-04-12T21:38:07Z

frontend/src/components/ManageApplicationsTable/ManageApplicationsTable.tsx

-  const exportToSheet = useGenerateSheetEventApplication(eventId, {
-    request: {
-      responseType: "blob",
+  const handleEditApplication = useCallback(


Why the use of useCallback?

slabys · 2026-04-12T21:38:49Z

frontend/src/components/ManageApplicationsTable/ManageApplicationsTable.tsx

-      },
-    });
-  };
+  const handleChangeApplicationSpot = useCallback(


Why the use of useCallback?

slabys · 2026-04-12T21:43:22Z

frontend/src/components/data-table/organisation-management-columns.tsx

+    id: "legalName",
+    accessorKey: "legalName",
+    header: ({ column }) => <DataTableColumnHeader column={column} title="Legal Name" />,
+    enableSorting: false,


Enable sorting

slabys · 2026-04-12T21:47:24Z

backend/apps/api/src/modules/events/events.controller.ts

 		if (!event) throw new NotFoundException("Event not found");
+
+		if (
+			event.until < new Date() &&


dayjs comparison can be used

slabys reviewed Mar 28, 2026

View reviewed changes

Alpha871 added 2 commits April 3, 2026 20:05

Rename docker-compose.yml to compose.yml

fa9e00a

Alpha871 force-pushed the feature/all-updates branch from 7fe50a9 to fa9e00a Compare April 3, 2026 17:07

Alpha871 added 5 commits April 3, 2026 20:10

Remove duplicate event-priority-list-deadline migration

1cb9369

Replace ManageApplicationsTable with reusable DataTable component

4588e82

- Use ApplicationManagementColumns with DataTable instead of raw Mantine Table - Memoize columns and data for stable TanStack Table references - Remove unused Table/ScrollArea imports

Revert: rollback to last stable review

da20673

slabys requested changes Apr 12, 2026

View reviewed changes

		@@ -0,0 +1,15 @@
		import { MigrationInterface, QueryRunner } from "typeorm";

		export class EventPriorityListDeadline1769500000000 implements MigrationInterface {

Conversation

Alpha871 commented Mar 27, 2026 • edited by slabys Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Alpha871 Apr 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

slabys commented Mar 28, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Alpha871 commented Mar 27, 2026 •

edited by slabys

Loading

Alpha871 Apr 6, 2026 •

edited

Loading