Completing support for Bearer tokens which were initially half-supported#309
Merged
mathieucarbou merged 1 commit intomainfrom Oct 10, 2025
Merged
Completing support for Bearer tokens which were initially half-supported#309mathieucarbou merged 1 commit intomainfrom
mathieucarbou merged 1 commit intomainfrom
Conversation
mathieucarbou
force-pushed
the
auth
branch
3 times, most recently
from
8205e5d to
914e6fa
Compare
me-no-dev
approved these changes
Oct 9, 2025
willmmiles
approved these changes
Oct 9, 2025
willmmiles
left a comment
willmmiles
left a comment
There was a problem hiding this comment.
Looks OK to me - the examples are very helpful. I don't love having _authcFunc delegate back to request->authenticate(), though I would agree that refactoring that is out of scope for this PR. We could consider having setAuthType() take responsibiltiy for assigning _authcFunc for the other auth types to eliminate the switch-case in allowed(), but that's a bit of a micro-optimization at best.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes incomplete Bearer token support in the library.
See discussion: #308