[fix] 다이나믹 폰트 적용 후 Subheader 컨텐츠가 잘리는 이슈 개선#658
Merged
Conversation
kitcat-s
requested review from
jihyeonjjang,
kanghun1121 and
leekangho0
and removed request for
kanghun1121
kitcat-s
requested review from
HyeonjinBack,
aldalddl,
ibcylon and
kanghun1121
leekangho0
approved these changes
Oct 28, 2025
| /// 헤더뷰와 배경 그래디언트 크기에도 영향을 주기 때문에 | ||
| /// 여기에서 계산 후 헤더뷰에게 전파 | ||
| var dynamicHeaderHeight: CGFloat { | ||
| switch typeSize { |
Collaborator
There was a problem hiding this comment.
typeSize라는게 있는 걸 처음봤네요
더 reponsive한 앱 같네요!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣ 연관된 이슈
📝 작업 내용
스크린샷 (선택)
좌 before, 우 after
💬 리뷰 요구사항(선택)
글이 말줄임표되는 이슈는 fixedSize로 없애고,
헤더와 카드 간의 간격이 좁아지는 이슈는 typeSize를 이용해 헤더 높이를 변경하는 방식으로 해결했는데
다른 해결 방법이 없는지 확신이 안서네요 ㅎㅎ
그라디언트 배경을 카드 크기의 반만 채워지게 디자인한 부분부터가 문제의 시작이었던 것 같으나
디자인적으로 다른 수를 찾을 수 없었다는 변명을 한 번 해봅니다 허허..