Conversation
|
First, a quality-of-life improvement with adding an issue template. |
|
That seems good to me. I suppose we could add the original S-L description in the 1999 paper, but the recent other paper(s) are more complete and refer to the 1999 paper, and that paper doesn't describe EXP per se. |
|
To keep notes in the same place: #95 is being addressed in the relevant repositories, see links in that issue. |
|
Following up on openjournals/joss-reviews#7302 (comment): We've updated and run through the tutorials using the latest main branch of EXP (which is also the Docker image), and think we've caught all the bugs now! |
|
|
||
| - Blog about EXP. Cite the EXP published papers (using | ||
| the papers in `CITATIONS.bib`). Tell the world how | ||
| the papers in [`CITATIONS.bib`](https://github.com/EXP-code/EXP/blob/main/CITATIONS.bib)). Tell the world how |
There was a problem hiding this comment.
Note that this link won't work until merge.
|
Addressing openjournals/joss-reviews#7302 (comment): We've added a CITATIONS.bib; this will also update upon JOSS acceptance to include the citation! |
|
I believe the last un-addressed comment is openjournals/joss-reviews#7302 (comment):
|
|
As I understand it, the idea is to improve the tutorial walk through showing both code input & output. It's a good idea but one that would take a bit of time. My take on the comment is the suggestion to save screenshots from the browser running Jupyter to svg. There is a Firefox extension for that, I believe. Random bitmapped graphics won't be improved by svg. |
|
Many of the |
|
@The9Cat has helpfully set up a notebook renderer in EXP-code/EXP-docs#33. This means that for readthedocs, notebooks that are generated as part of the tutorials in We'll merge this in to This addresses openjournals/joss-reviews#7302 (comment). |
|
The last commit included a few additional wording fixes, added a note about the data to run the examples, and added navigation stubs to the imported ipynb files back to the Github pyEXP-examples repo. Looks fine to me now. |
|
@The9Cat, we've received word this satisfies the reviewers -- can you take a quick look and approve+merge when ready? |
|
Sure, I'll take a quick look now. I've already reviewed this casually and didn't find any issues. |
There are several adjustments and improvements to make as part of the JOSS review process; this branch will handle them in one place.