Ensure that FlatDisk has a background if M0_BACK is selected in PolarBasis#109
Merged
Ensure that FlatDisk has a background if M0_BACK is selected in PolarBasis#109
FlatDisk has a background if M0_BACK is selected in PolarBasis#109Conversation
added 4 commits
February 2, 2025 18:51
…dard exception rather than terminate if provided directory does not exist
Member
Author
|
Ooops, looks like I branched off the previous PR branch rather than |
The9Cat
changed the title
FlatDisk has a backround if M0_BACK is selected in PolarBasisFlatDisk has a background if M0_BACK is selected in PolarBasis
michael-petersen
approved these changes
Apr 2, 2025
Member
michael-petersen
left a comment
michael-petersen
left a comment
There was a problem hiding this comment.
Whoops, this slipped through the review cracks until now. Tested compile; didn't test the features as I don't have a MWE set up for this. But if it works for you, let's merge!
Member
Author
|
This PR is mostly sanity checking for options and one minor fix for the VTK file writing (col-major). I'll merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This minor change checks that the user has specified a background potential if
M0_BACKis selected. Otherwise,expwill seg fault by trying to call a null function. That is not pretty. It's really a user error but no one wants to see a seg fault.