orthoCheck Python wrapper is missing its argument#113
Conversation
…missing functionality
|
michael-petersen
left a comment
There was a problem hiding this comment.
All good fixes. Nice catch on the spherical velocities -- a properly annoying bug!
Our other enhancement debate is whether we want to build an orthocheck into the spherical basis by default before constructing a Cylinder basis. I could go either way on this; maybe something for the future.
|
I think that's a good idea. It's trivial do since the |
michael-petersen
left a comment
There was a problem hiding this comment.
Great, this is a fantastic enhancement! We'll have to see how orthoCheck performs in the wild, but my fiducial basis construction worked just fine. I'm in favour of merging this and then sorting out edge cases later if any appear.
It's very trivial. But it's a bug.
The original implementation documented an argument, but the no-argument default was called instead. The fix includes both bindings.