A few tweaks to build exp with clang++ on mac via gala build#132
A few tweaks to build exp with clang++ on mac via gala build#132The9Cat merged 2 commits intoEXP-code:mainfrom
Conversation
There was a problem hiding this comment.
Totally legit. Not sure why clang++ did not auto deduce the typename from the previously declared parameter. Maybe that's actually c++-20? I think that bit of the standards really is c++17 Clang++ is often more strict than g++ but not always 100% compliant. E.g. they still haven't implemented all of the std mathematically special functions which required all sorts of workarounds.
|
No problems with this change on my end either (M1 mac with clang), but a bit of a mystery why this wouldn't have thrown an issue in the CI clang tests or earlier compiles. But no harm done with this change, of course! |
|
Yea it is a bit strange! I actually don't see a problem when I build EXP standalone, but when I build Cython code that includes EXP code, then I get this error. (guessing) It might be a quirk of using EXP in a header-only way? |
|
Is this a link error or compile error? If it's a link error, then, yes, the object code needs to have the compiled template with the typename needed, |
|
It was a compile error I believe |
|
Strange. The EXP github CI compiles with clang successfully. Not sure which clang version in the their runtime image. |
adrn
changed the title
|
Hm, why isn't CI running on my latest commit? |
|
I'm not 100% sure, but I think that you need to run the workflow on pull_request, e.g. on: [push, pull_request] |
|
Built in gcc environment with no issues. Merging and closing. |
3 participants
Working on the Gala <--> EXP connection on my laptop and so using clang++ for compiling (out of convenience). Clang threw an error about this -- is this a sensible fix?