Conversation
…eal with HighFive row-major storage
…wCoefs' and completely deprecreate the old binary cache format
|
While sensitive about changing the behavior of an mSSA configuration feature "on the fly", these flags are undocumented, experimental parameters used in a non standard way. Their existence is the toggle unlike other switches which are boolean. So promoting these to boolean with I would like to see an implementation of a more general facility detrending options. I'm thinking of a class that provides a detrending and retrending functors for each channel that allow a general time dependent rescaling that a user might define from Python. However, developing this will require additional thought and testing. |
Added spaces for readability
The9Cat
left a comment
There was a problem hiding this comment.
This all looks good. I will open the desire for a more general detrending functionality as an issue.
This PR promotes
totPowandtotVartobools and sets rules for when both are set.Bigger questions: