Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces some top-level cosmetic changes including adding the JOSS badge to the README and cleaning up obsolete files.
- Added a DOI badge in the README.md
- Removed outdated NEWS, Exception.H, and AUTHORS files
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| README.md | Added a JOSS badge to display DOI status |
| NEWS | Removed outdated changelog information |
| Exception.H | Removed exception handling header; verify if it’s no longer needed |
| AUTHORS | Removed redundant authors attribution file |
Comments suppressed due to low confidence (1)
Exception.H:1
- The entire Exception.H file is being removed, which may break exception handling if its classes are still referenced elsewhere in the codebase. Please verify that this deletion is intentional and that any dependencies on these exception types have been addressed.
// -*- C++ -*-
Member
|
This all looks good to me. Yes, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the JOSS badge to the README.md and updates the rendered PDF paper to the most recent version.
It also cleans up some extra files that have been in the top-level directory for a while, but haven't been used. I'm not sure if these are all the changes we want to make; still mulling that over.