Merged
Conversation
added 3 commits
July 18, 2025 12:46
…rflow while computing basis elements with large harmonic orders
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an MPI spinlock bug in OutDiag caused by parameter tag parsing occurring after non-root nodes return early. The fix moves the initialize() call to the beginning of the constructor.
- Moved
initialize()call from end to beginning of OutDiag constructor - Added static variables for Rmin heuristic grid construction parameters
- Implemented radial boundary heuristics in SLGridMP2 to prevent underflow in Sturm-Liouville solver
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/OutDiag.cc | Moved initialize() call to prevent MPI spinlock |
| include/SLGridMP2.H | Added static variables for grid construction heuristics |
| exputil/SLGridMP2.cc | Implemented radial boundary logic and enhanced diagnostics |
Thank you, copilot. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Member
|
This looks good; my only comment is that this is a bug in main, so should we be patching there? |
Member
Author
|
We could rebase this to main. Appropriate because it's a simple bug with no other |
Member
|
Okay, putting this in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue
Parameter tag parsing in
initialize()comes after non-root node return in constructor, causing an MPI spinlock.Fix
Call
initialize()at the top of the constructor.Tested.