Merged
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…t ChaNGa is doing for particle ID.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds MPI-aware parallel partitioning support for tipsy file reading to enable per-process data distribution instead of requiring each process to read the entire file.
- Added MPI-based partitioning logic for both XDR and native tipsy file readers
- Implemented robust exception handling using
std::runtime_error - Added utility function for initializing C++ MPI communicators from pyEXP
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| pyEXP/UtilWrappers.cc | Adds setMPI function to initialize C++ MPI communicators and variables |
| include/tipsy.H | Updates tipsy header structures and adds parallel reading support with index offset tracking |
| include/SLGridMP2.H | Adds static variables for radial boundary heuristics in grid construction |
| include/ParticleReader.H | Updates constructors and adds new Bonsai type for ID handling |
| exputil/SLGridMP2.cc | Implements radial boundary heuristics and improved error diagnostics |
| exputil/ParticleReader.cc | Updates constructors and implements new Bonsai ID handling logic |
| expui/Centering.cc | Fixes increment operator placement in loop condition |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sure. I agree that pre-increment better represents the intent. Although post-increment is not wrong either. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
michael-petersen
approved these changes
Sep 29, 2025
Member
michael-petersen
left a comment
There was a problem hiding this comment.
I don't have any files available to test this -- we might want to consider something like that for a test -- but everything here makes sense.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue
Current implementation of tipsy file reading does not allow for per-process partitioning. This requires each process to read the entire file.
Fix
std::runtime_errorclass for exception handlingpyEXPutility for intialized C++ side MPI communicators and variables. Not necessary for MPI coefficient generation but will be helpful for other C++ MPI aware classesNotes
mpi4pyon one of Jason's large Bonsai-generated simulation snapshots