Two minor fixes necessary for successful compilation with g++15#158
Merged
michael-petersen merged 2 commits intodevelfrom Sep 29, 2025
Merged
Two minor fixes necessary for successful compilation with g++15#158michael-petersen merged 2 commits intodevelfrom
michael-petersen merged 2 commits intodevelfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses compilation issues with g++15 by fixing header dependencies and removing deprecated type redefinition patterns.
- Adds necessary
<cstdint>includes for explicit integer types required by g++15 - Replaces custom boolean type definitions with standard C
<stdbool.h>implementation - Sets C standard to C17 in CMake configuration
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| include/cxxopts.H | Adds <cstdint> include for uint types |
| exputil/GaussCore.c | Replaces custom bool typedef with standard <stdbool.h> |
| expui/ParticleIterator.H | Adds <cstdint> include for integer types |
| CMakeLists.txt | Sets C standard to C17 for stdbool.h compatibility |
Comments suppressed due to low confidence (1)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
michael-petersen
approved these changes
Sep 29, 2025
Member
michael-petersen
left a comment
There was a problem hiding this comment.
All seems good here, I've compiled on MacOS with no trouble.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
<cstdint>and this header needs to be included for things likeuint*_t.GaussCorecode uses some type redefinition trickery which is now illegal in g++15. This results from gcc-15 supporting C23 which addsboolas an official key word sotypedef int bool;is now an error. Updated by removing theat typedef in favor of a realboolC17 bool type.Notes
I have not checked gcc 15 with Cuda