Updates to DEBUG diagnostic code#163
Merged
michael-petersen merged 1 commit intodevelfrom Oct 1, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates debugging code within #ifdef DEBUG blocks to maintain consistency with current development code. The changes address compilation issues and synchronize variable names used in debug statements.
- Added missing
unistd.hheader includes to enable Unixsleep()function usage in debugging - Updated variable names in orbit-related debug output to match current code (EE→energy, KK→kappa)
- Fixed a missing semicolon in debug output statement
Reviewed Changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| utils/ICs/initial2d.cc | Fixed missing semicolon in debug output statement |
| Multiple utils/Analysis/*.cc files | Added missing unistd.h include for debug sleep() functionality |
| src/ParticleFerry.cc | Removed obsolete debug function calls |
| exputil/realize_model.cc | Updated function calls and variable references in debug code |
| exputil/orbit_trans.cc | Updated variable names in debug messages from EE/KK to energy/kappa |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
michael-petersen
approved these changes
Oct 1, 2025
Member
michael-petersen
left a comment
There was a problem hiding this comment.
Looks good to me. Yes a lot of files touched, but mostly header addition. No problems in CI, so I'll merge this in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings code in
ifdef DEBUGblocks up to date with the currentdevelcode. The main changes are:unistd.hheader for Unixsleep()used for debuggingorbitfor energy and kappa variablesDespite the number of files involved, this is a rather minor update.