Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds an array version of the getAccel method by creating an overload that aliases to the existing getAccelArray function. The change provides a more Pythonic interface for vector operations while maintaining backward compatibility.
- Adds a new
getAccelmethod overload that callsgetAccelArrayinternally - Includes comprehensive documentation for the new method
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…the pybind11 interface accordingly.
5 tasks
cmake: add more headers used from public interface
…t to getAccel(); both vector and matrix input interace is checked against scalar version
Member
Author
|
Everything in the new interface checks and should not break existing code. Going to merge. |
lgarrison
added a commit
to adrn/gala
that referenced
this pull request
Oct 29, 2025
Previously, we had a frankenstein build that pulled from the EXP repo, build dir, and install dir. Now with EXP-code/EXP#170, everything we need is in the EXP install dir, including EXP's vendored dependencies.
6 tasks
adrn
pushed a commit
to adrn/gala
that referenced
this pull request
Nov 6, 2025
Previously, we had a frankenstein build that pulled from the EXP repo, build dir, and install dir. Now with EXP-code/EXP#170, everything we need is in the EXP install dir, including EXP's vendored dependencies.
adrn
pushed a commit
to adrn/gala
that referenced
this pull request
Dec 10, 2025
Previously, we had a frankenstein build that pulled from the EXP repo, build dir, and install dir. Now with EXP-code/EXP#170, everything we need is in the EXP install dir, including EXP's vendored dependencies.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provides an overload from
getAccelArraytogetAccelto provide the Pythonic vector version as an overload. This is simply an name alias in the pybind11 interface at this point. Could be optimized in the future.Requested by @adrn