Scope functions and variables so that static libraries build

[Leengit]

Without these changes, I cannot build when CMakeLists.txt is modified to have

option(BUILD_SHARED_LIBS "Build using shared libraries" OFF)

The changes are:

1. Add static and/or inline to functions defined in header files so that they are not publicly instantiated in multiple object files.
2. Remove definitions of global variables numprocs, proc_namelen, and processor_name from several files so that they do not duplicate nor hide those defined in exputil/localmpi.cc.

Note: with these changes, the build still works when I leave CMakeLists.txt with

option(BUILD_SHARED_LIBS "Build using shared libraries" ON)

[The9Cat]

Thanks. Those look like reasonable changes. I'll queue them up for testing. If we supply a static library option, than it should work! TBH, we don't usually use this ourselves so I haven't tested this recently and it's not part of our CI. A static build probably can not be made to worth with Python support. So we may need to make that an exclusive behavior with ENABLE_PYTHON and ENABLE_PYTHON_ONLY. Or remove the static option altogether. You are the first in a while who has asked about this. May I ask why you need static libraries?

If you are looking for a minimal build of EXP that contains only the key C++ interface without any of the driver binaries, you might try the ENABLE_MINIMAL option available in the devel branch. That will generate only libexpui and libexputil. I'm fairly sure that will compile static.

[Leengit]

May I ask why you need static libraries?

I'm looking to include some EXP functionality in open source code that we often ship as binaries (for Linux, Microsoft Windows). The hope is to keep both the number of files and number of bytes down, and we're exploring whether static libraries achieves that better than shared libraries. I'll take a look at ENABLE_MINIMAL too; thanks for the heads up!

[The9Cat]

Got it. Static libs will almost always be larger than shared libs because they include all of their dependencies. The libexpui is the primary library needed by any clients compiling against EXP. The 'ui' stands for user-interface here. That should be all you need. In Ubuntu, the shared version is 3.4M (and it needs libexputil for support which is 3.8M) so the total is 7.2M. The static version of libexpui.a is 9.0M and that should be all you need. So in this case, it might depend on what other system stuff is in the image.

[Leengit]

Static libs will almost always be larger than shared libs

Apologies for the sloppy response I gave earlier. The hope is that compiling/linking the executable against the static libraries will bring into the executable only the parts (i.e. underlying object files (*.o)) from the static libraries that are strictly necessary. We'd then ship the executable binary, but not the libraries themselves. The experiment, still underway, is to determine whether that gives a substantially smaller footprint.

[The9Cat]

I've rebased against devel. Since you probably want that branch for your purposes anyway. All tests are successful. I'm going to merge this.