Fix faulty definitions in base Milky Way model#175
Merged
michael-petersen merged 1 commit intodevelfrom Nov 30, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR corrects critical coordinate system errors in the Milky Way potential model implementation. The changes fix the radius calculations in four potential components to match their proper geometric symmetries: spherically symmetric components (NFW halo, Hernquist nucleus and bulge) now correctly use 3D radius, while the axisymmetric disk component (Miyamoto-Nagai) now correctly uses cylindrical radius.
Key changes:
- Fixed three spherically symmetric potentials (halo, nucleus, bulge) to use 3D spherical radius r = sqrt(x² + y² + z²)
- Fixed the axisymmetric disk potential to use 2D cylindrical radius R = sqrt(x² + y²)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issues in the definitions of the Milky Way potential that is currently offered as an external potential example.
Note that this potential matches
MilkyWayPotentialingala(notMilkyWayPotential2022, which might be preferable).