Remove the dependence on the reduced-memory Particle class#204
Merged
michael-petersen merged 1 commit intodevelfrom Feb 26, 2026
Merged
Remove the dependence on the reduced-memory Particle class#204michael-petersen merged 1 commit intodevelfrom
michael-petersen merged 1 commit intodevelfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes a redundant reduced-memory Particle class definition from utils/Analysis/Particle.h and the associated includes in four utility files. The reduced class was used to lower memory footprint but caused maintenance confusion and compatibility issues on case-insensitive filesystems where compilers couldn't distinguish between utils/Analysis/Particle.h and include/Particle.H.
Changes:
- Removes the reduced
Particle.hfile fromutils/Analysis/ - Removes
#include "Particle.h"from four utility files that never directly used the Particle class - Simplifies the codebase by relying solely on the canonical
include/Particle.Hdefinition
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| utils/Analysis/Particle.h | Completely removed - eliminated the reduced-memory Particle class definition |
| utils/Analysis/xval_cyl.cc | Removed unused Particle.h include; uses PSP2.H's SParticle instead |
| utils/Analysis/mssaprof_halo.cc | Removed unused Particle.h include; doesn't use Particle class at all |
| utils/Analysis/haloprof_coef.cc | Removed unused Particle.h include; doesn't use Particle class at all |
| utils/Analysis/diskprof_coef.cc | Removed unused Particle.h include; doesn't use Particle class at all |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
michael-petersen
approved these changes
Feb 26, 2026
Member
michael-petersen
left a comment
There was a problem hiding this comment.
Nice straightforward bit of cleanup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Routines in
utils/Analysisused aParticleclass with a reduced number of fields to lower the memory footprint. This is a bit confusing for maintenance and confuses compilers that do not distinguish file names by case (like clang).Since the reduced
Particleclass is consistent with the fullParticleclass defined ininclude, this PR simply removes reference to the reduced version and uses the original.