Skip to content

Remove the dependence on the reduced-memory Particle class#204

Merged
michael-petersen merged 1 commit intodevelfrom
NoReducedParticle
Feb 26, 2026
Merged

Remove the dependence on the reduced-memory Particle class#204
michael-petersen merged 1 commit intodevelfrom
NoReducedParticle

Conversation

@The9Cat
Copy link
Member

@The9Cat The9Cat commented Feb 25, 2026

Summary

Routines in utils/Analysis used a Particle class with a reduced number of fields to lower the memory footprint. This is a bit confusing for maintenance and confuses compilers that do not distinguish file names by case (like clang).

Since the reduced Particle class is consistent with the full Particle class defined in include, this PR simply removes reference to the reduced version and uses the original.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes a redundant reduced-memory Particle class definition from utils/Analysis/Particle.h and the associated includes in four utility files. The reduced class was used to lower memory footprint but caused maintenance confusion and compatibility issues on case-insensitive filesystems where compilers couldn't distinguish between utils/Analysis/Particle.h and include/Particle.H.

Changes:

  • Removes the reduced Particle.h file from utils/Analysis/
  • Removes #include "Particle.h" from four utility files that never directly used the Particle class
  • Simplifies the codebase by relying solely on the canonical include/Particle.H definition

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
utils/Analysis/Particle.h Completely removed - eliminated the reduced-memory Particle class definition
utils/Analysis/xval_cyl.cc Removed unused Particle.h include; uses PSP2.H's SParticle instead
utils/Analysis/mssaprof_halo.cc Removed unused Particle.h include; doesn't use Particle class at all
utils/Analysis/haloprof_coef.cc Removed unused Particle.h include; doesn't use Particle class at all
utils/Analysis/diskprof_coef.cc Removed unused Particle.h include; doesn't use Particle class at all

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@michael-petersen michael-petersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice straightforward bit of cleanup.

@michael-petersen michael-petersen merged commit 6b7dd2a into devel Feb 26, 2026
12 checks passed
@michael-petersen michael-petersen deleted the NoReducedParticle branch February 26, 2026 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants