Fix thread-unsafe lazy initialization in ExpDeproj::mass()#205
Merged
The9Cat merged 2 commits intoSphericalExactfrom Feb 25, 2026
Merged
Fix thread-unsafe lazy initialization in ExpDeproj::mass()#205The9Cat merged 2 commits intoSphericalExactfrom
The9Cat merged 2 commits intoSphericalExactfrom
Conversation
Co-authored-by: The9Cat <25960766+The9Cat@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Work in progress on deprojection feedback for exponential surface density
Fix thread-unsafe lazy initialization in ExpDeproj::mass()
Feb 25, 2026
The9Cat
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ExpDeproj::mass()used lazy initialization guarded only by a size check, making it unsafe for concurrent calls before the grid was populated.Changes
include/ExpDeproj.H: Moveinitialize()call into the constructor, eliminating lazy init entirely.exputil/ExpDeproj.cc: Remove the now-redundantmv.size() == 0guard frommass().Grid is now computed once at construction time, before any thread can invoke
mass().💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.