Fix incomplete valid mtype list in check_coefs.cc error message#207
Merged
The9Cat merged 2 commits intoSphericalExactfrom Feb 25, 2026
Merged
Fix incomplete valid mtype list in check_coefs.cc error message#207The9Cat merged 2 commits intoSphericalExactfrom
The9Cat merged 2 commits intoSphericalExactfrom
Conversation
Co-authored-by: The9Cat <25960766+The9Cat@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback from review on spherical basis deprojection PR
Fix incomplete valid mtype list in check_coefs.cc error message
Feb 25, 2026
The9Cat
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The error message in
check_coefs.ccfor unrecognizedmtypevalues listed onlyExponential, Gaussian, Plummer, omittingExpSphereandPower— both of which were already handled in the same block. This made the error misleading for users passing valid types that weren't listed.Changes
utils/ICs/check_coefs.cc: Updated the fallthrough error message to matchcheck_coefs2.cc:💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.