Merged
Conversation
…nclude HDF5++ library needed by ParticleReader
Member
|
All checks passed; this compiled locally for me on another Ubuntu 24.04 machine and a M1 Mac. Looks good to me! |
michael-petersen
approved these changes
Dec 16, 2024
Member
michael-petersen
left a comment
michael-petersen
left a comment
There was a problem hiding this comment.
Light changes; no problems for me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two very tiny updates that belong in
main:rpathrewriting on install by defaultexputilbuild config to include HDF5++ library needed byParticleReader. This is needed for 24.04 and was accidentally removed during the pip+conda merge