fix(ci) un-trip Sanitization on its own DL-0004 documentation#101
Merged
Conversation
DL-0004 (decision-log.md) and the Phase 2 § Hand-off-outcomes Item 9 retrospective in build-spec.md document the local grep-based verification protocol for the Sanitization workflow. They contained the verbatim regex strings (`jim@earlybird`, `@earlybirdsolutions`, and the synthetic placeholder examples that match those patterns) as code-fenced examples in a pattern-validation table. The Sanitization workflow's `run_rule` invocations grep case-insensitively across the entire checkout (excluding only `sanitization.yml` itself). A document that quotes the patterns verbatim trips the very rules it documents — recursive trap. PRs #99 and #100 are currently blocked on this; #96/#97/#98 slipped through (likely because the docs landed earlier than the workflow's current sensitivity, OR push-event runs failed non-blockingly). Fix: mask the literal `@` with `<at>` in the two docs' example strings. Patterns remain readable to humans, are clearly labeled as intentionally-masked (with a forward-pointer to this PR's rationale), and no longer match the workflow's regex. The masking convention is now documented inline in DL-0004 so future authors don't reintroduce the trap. Verified locally: `git grep -niE "jim@earlybird|@earlybirdsolutions"` now only hits `sanitization.yml` (which is excluded from the scan per its own `--exclude=sanitization.yml` flag). After this merges, PRs #99 and #100 should retrigger CI cleanly and unblock the W1-3 hardening + OPDB blank-string fix chain (operator hand-off chain documented in PR #100's body).
This was referenced May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DL-0004 (decision-log.md) and the Phase 2 § Hand-off-outcomes Item 9 retrospective in build-spec.md document the local grep-based verification protocol for the Sanitization workflow. They contained the verbatim regex strings (
jim<at>earlybird,<at>earlybirdsolutions, written here masked) as code-fenced examples in a pattern-validation table.The Sanitization workflow's
run_ruleinvocations grep case-insensitively across the entire checkout (excluding onlysanitization.ymlitself via--exclude=sanitization.yml). A document that quotes the patterns verbatim trips the very rules it documents — recursive trap.Blast radius. PRs #99 (W1-3 hardening) and #100 (OPDB blank-string fix) are both currently blocked on the Sanitization check failing. PRs #96/#97/#98 slipped through earlier — likely because the strings landed before the workflow's current sensitivity profile, OR because push-event runs failed non-blockingly while pull_request runs only started failing after some unrelated change.
Fix. Mask the literal
@with<at>in the two docs' example strings. Patterns remain readable, are clearly labeled as intentionally-masked (with a forward-pointer note explaining why), and no longer match the workflow's regex. The masking convention is documented inline in DL-0004 so future authors don't reintroduce the trap.Test Plan
git grep -niE "jim@earlybird|@earlybirdsolutions"now only hitssanitization.yml(which is excluded from the scan per its own--exclude=sanitization.ymlflag) — verified locallyOut of Scope
WORK_EMAIL_PATTERNprecedent). That would let the docs reference the patterns by name without reproducing them. Tracked as a Phase 4.x follow-up; this PR is the surgical unblock.Operator follow-up after this merges
Dev-Phase4W13RecurateHardening(PR chore(eval) Phase 4 W1-3 hardening — mfg-aware re-curation skip-on-mismatch #99) to retrigger CI.Dev-Phase4OpdbMapperEmptyStringFix(PR fix(opdb) treat blank strings as null in OpdbMachineMapper fallback chain #100) to retrigger CI.Checklist
~/.claude/projects/c--projects-PinballWizard/memory/is now stale, it has been updated or removed — N/ATODO/FIXME/ commented-out code committed<NoWarn>without a comment — N/APre-push self-audit
Step 0 —
/local-review(qualitative).claude/skills/local-review/SKILL.md§ "When to invoke": doc-only PRs and pure dependency bumps may skip.Step 1 — Mechanical checklist
*Optionsproperty has at least one real getter call insrc/— N/Acatch { }— N/AISourceScraper? — N/Agit log -1 --format='%an <%ae>'shows personal noreply, not work email — confirmed94459922+jkeeley2073@users.noreply.github.com