Reframe project principle: enterprise-quality portfolio bar#3
Closed
jkeeley2073 wants to merge 0 commit into
Closed
Reframe project principle: enterprise-quality portfolio bar#3jkeeley2073 wants to merge 0 commit into
jkeeley2073 wants to merge 0 commit into
Conversation
7 tasks
jkeeley2073
added a commit
that referenced
this pull request
May 4, 2026
Per /local-review on PR #68: grep -E exits 2 on a malformed extended regex, but run_rule wraps the grep call with `|| true` which masks exit 2 as "no match" — silently disabling the rule. A typo in the WORK_EMAIL_PATTERN secret would pass the workflow without ever checking commits against the work-email pattern. The narrow fix: pre-validate the pattern by running it against an empty stdin via printf '' | grep -E "$WORK_EMAIL_PATTERN" and checking grep's exit code directly. Exit 2 = malformed pattern, fail the workflow with an error annotation that names the issue and points the operator at how to fix the secret. Exit 0 (matches empty) or 1 (no match against empty) → pattern is well-formed, proceed to run_rule normally. The broader cleanup of run_rule itself (distinguishing grep exit codes 0/1/2 for every rule) is out of scope for this PR — the narrow fix here addresses the new rule's specific risk without touching pre-existing behavior of the other rules. Local review summary (retroactive on PR #68): 0 🔴, 3⚠️ findings. -⚠️ #1 (post-merge smoke test): already covered in the PR description's "Validation hand-off after merge" section. -⚠️ #2 (grep exit-2 silent swallow): fixed by this commit. -⚠️ #3 (doc-anchor verification): the comment cites "docs/build-spec.md Phase 2 § Scope item 9" which exists at build-spec.md:225 — verified, no change needed.
jkeeley2073
force-pushed
the
Dev-EnterpriseQualityFraming
branch
from
4b83268 to
bc8230d
Compare
Contributor
Author
|
Closing context for the record: The intent — reframe the project posture from "hobby — keep it simple" to enterprise-quality — was fully accomplished by the spec system rewrite (PR #64) and is now extensively present in main's CLAUDE.md:
The "Project principles" bullet list this PR targeted no longer exists in CLAUDE.md — it was deliberately replaced by the canonical spec system ( |
This was referenced May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
One-line change to
CLAUDE.mdto update the project's stated quality bar from "hobby project, keep it simple" to enterprise-quality portfolio framing. The repo is now public and serves as portfolio evidence of professional work; the previous principle nudged toward shortcuts on testing, observability, and hygiene that are baseline expectations for portfolio-grade code.The "keep it simple" intent is preserved (don't add speculative abstractions) but the bar around CI/CD, zero warnings, structured logging, metrics, dependency scanning, lockfile, integration tests, deterministic builds, and license/contributor docs is now explicit.
Test plan
git diff --stat→ 1 file changed, 1 insertion, 1 deletion (literally just the principle bullet)Why merge this alone
Locks the framing in
maindurably so it persists across sessions and reviewers. Subsequent enterprise-readiness work (zero-warning enforcement, CI/CD, etc.) gets sequenced into separate PRs, each tied to a specific gap.