test(infra) Multimorphic scraper-pipeline integration tests#48
Merged
Conversation
Backfill of the PR #41 template across the family. 5 tests covering happy-path with full provenance + gate-vs-wire URL equality, per-page failure isolation, sitemap discovery failure, PolitenessException on both Acquire and Report. Single-yield (.Game only) WordPress storefront via /wp-sitemap.xml walk filtered to /store/p3-game-kits/multimorphic-game-kits/. Pre-push audit: 7-item mechanical (all pass). /local-review deferred to human reviewer at merge time.
e678e8f to
87daf96
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backfill of the PR #41 family-wide test-infra template for
MultimorphicProductScraper. 5 scraper-pipeline integration tests covering the audit-flagged invariants the unit-test surface cannot reach./wp-sitemap.xml->wp-sitemap-posts-product-1.xml-> per-product HTML pages, filtered to/store/p3-game-kits/multimorphic-game-kits/{slug}/..Gameonly (no.Link).SourceType.MultimorphicProductPage, discovery context"Multimorphic Game Kit".Tests added
ScrapeAsync_HappyPath_YieldsGamesInSitemapOrderWithProvenance— sitemap index XML -> product sub-sitemap XML (with third-party kit + circuit board mixed in to pin the prefix filter) -> 3 product HTML pages. Asserts: yield count + slug order, full provenance (SourceType, DiscoveryContext, DiscoveryUrl, Source.ScrapedFrom, ScrapedAt, DiscoveredOn), gate-vs-wire URL byte-equality, exact wire-trace (5 requests: index + sub-sitemap + 3 products, no third-party / circuit board).ScrapeAsync_PerPageFetchFailure_DoesNotAbortRun— middle product page returns 500; siblings still yield; politeness invariants hold under failure (the 500 is reported back).ScrapeAsync_DiscoveryFailure_AbortsThisSourceOnly— sitemap index returns 500; scraper yields nothing AND does not throw (clean yield-break for orchestrator).ScrapeAsync_PolitenessExceptionFromGate_PropagatesUp—ThrowOnAcquireinjectsPolitenessException; wire shows zero requests, gate shows zero reports.ScrapeAsync_GateThrowsOnReport_BubblesUp— symmetric:ThrowOnReportpropagates.Test count: 430 -> 435.
Pre-push self-audit
/local-review: deferred to the reviewer at merge time (per task instruction).catch { }.multimorphicalias already wired in PR feat(multimorphic) Multimorphic scraper — Phase 1.3.c #39).Jim Keeley <94459922+jkeeley2073@users.noreply.github.com>(personal noreply).Test plan
dotnet buildclean (0 warnings)/local-reviewat merge timeHard constraints honored