feat: buildkit volume caching (experimental)#291
Conversation
|
| Branch | Total Count |
|---|---|
| main | 7 |
| This PR | 10 |
| Difference | +3 (42.86%) |
Keep up the great work migrating from Earthly to Earthbuild! 🚀
💡 Tips for finding more occurrences
Run locally to see detailed breakdown:
./.github/scripts/count-earthly.shNote that the goal is not to reach 0.
There is anticipated to be at least some occurences of earthly in the source code due to backwards compatibility with config files and language constructs.
There was a problem hiding this comment.
Code Review
This pull request implements an experimental buildkit volume caching mechanism for the setup-earthbuild action, enabling Docker volume persistence across workflow runs. The changes include new logic in the restore and save phases, updated dependencies, and additional tooling documentation. Review feedback indicates that the configuration inputs for this feature are currently commented out in action.yml and should be enabled. Additionally, the reviewer identified a resource management issue where temporary directories used for cache extraction and compression are not being deleted, which could lead to disk space exhaustion on persistent runners.
|
One thing to watch out for is cache poisoning - the same cache can be used potentially by malicious PRs and will also be used by main and possibly release processes. The cache keys need to be content addressable based and verified that they do contain what the key suggested they contain. |
No description provided.