Improve privileged mode error message with actionable suggestions#448
Open
danielschlegel wants to merge 6 commits into
Open
Improve privileged mode error message with actionable suggestions#448danielschlegel wants to merge 6 commits into
danielschlegel wants to merge 6 commits into
Conversation
danielschlegel
requested review from
kmannislands
and removed request for
a team
|
| Branch | Total Count |
|---|---|
| main | 5557 |
| This PR | 5569 |
| Difference | +12 (0.22%) |
📁 Changes by file type:
| File Type | Change |
|---|---|
| Go files (.go) | ❌ +8 |
| Documentation (.md) | ➖ No change |
| Earthfiles | ❌ +4 |
Keep up the great work migrating from Earthly to Earthbuild! 🚀
💡 Tips for finding more occurrences
Run locally to see detailed breakdown:
./.github/scripts/count-earthly.shNote that the goal is not to reach 0.
There is anticipated to be at least some occurences of earthly in the source code due to backwards compatibility with config files and language constructs.
danielschlegel
force-pushed
the
fix-issue-326-suggest-privileged-mode
branch
from
ffc8803 to
282f9d6
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request improves the error messaging when a build requires privileged mode but the -P flag is missing. It introduces more descriptive user messages, including target information when available, and provides clear instructions on how to resolve the issue. Additionally, it moves the help message printing to the logbus formatter and adds comprehensive integration tests. Feedback includes addressing potential duplicate output caused by the architectural change in the formatter, fixing a grammatical error in the user message, and removing a redundant flag check before calling VerboseWarnf.
danielschlegel
force-pushed
the
fix-issue-326-suggest-privileged-mode
branch
4 times, most recently
from
1c5e841 to
9729fdd
Compare
Replace cryptic 'unlazy force execution: failed to load LLB: security.insecure
is not allowed' error with clear, user-friendly message.
Changes:
- cmd/earthly/app/run.go: Create clear error message with 3 solution options
* Run with -P flag
* Set EARTHLY_ALLOW_PRIVILEGED environment variable
* Add to config file
* Technical details only shown with -V or --debug flags
- logbus/formatter/formatter.go: Print help message for build failures
- tests/with-docker/Earthfile: Add simple test target for privileged tests
- tests/Earthfile: Add comprehensive tests for all privileged operations
* RUN --privileged
* WITH DOCKER
* IF --privileged
* FOR --privileged
Before:
Error: build target: build main: failed to solve: unlazy force execution:
failed to load LLB: security.insecure is not allowed
Help: earth --allow-privileged (earth -P) flag is required
After:
Error: This build uses privileged operations which requires privileged mode.
Help: To fix this, use one of the following:
• Run with the -P flag: earth -P +your-target
• Set environment variable: export EARTHLY_ALLOW_PRIVILEGED=true
• Add to config: earth config global.allow_privileged true
Clean up error handling: remove duplicate HelpPrint calls and simplify verbose warning
danielschlegel
force-pushed
the
fix-issue-326-suggest-privileged-mode
branch
from
9729fdd to
5ebf72a
Compare
Open
janishorsts
reviewed
Apr 20, 2026
…f placeholder - Extract target from command line arguments when not available from interpreter error - Show specific command like 'earth -P +foobar' instead of generic 'earth -P +your-target' - Add comprehensive test suite for target extraction logic - Addresses feedback from @janishorsts to provide more meaningful error messages Fixes the issue where users had to mentally substitute the target placeholder with their actual target name in privileged mode error suggestions.
kmannislands
approved these changes
Apr 29, 2026
gilescope
approved these changes
Apr 29, 2026
janishorsts
reviewed
May 12, 2026
Comment on lines
+271
to
+276
| var flagExample string | ||
| if targetInfo != "" { | ||
| flagExample = fmt.Sprintf("earth -P %s", targetInfo) | ||
| } else { | ||
| flagExample = "earth -P +your-target" | ||
| } |
Collaborator
There was a problem hiding this comment.
Both code samples compile to the same binary code
Suggested change
| var flagExample string | |
| if targetInfo != "" { | |
| flagExample = fmt.Sprintf("earth -P %s", targetInfo) | |
| } else { | |
| flagExample = "earth -P +your-target" | |
| } | |
| flagExample := "earth -P +your-target" | |
| if targetInfo != "" { | |
| flagExample = fmt.Sprintf("earth -P %s", targetInfo) | |
| } |
janishorsts
reviewed
May 12, 2026
| ) | ||
| app.BaseCLI.Console().HelpPrint(helpMsg) | ||
|
|
||
| app.BaseCLI.Console().VerboseWarnf("Technical details: %v\n", err.Error()) |
Collaborator
There was a problem hiding this comment.
Suggested change
| app.BaseCLI.Console().VerboseWarnf("Technical details: %v\n", err.Error()) | |
| app.BaseCLI.Console().VerboseWarnf("Error: %s\n", err.Error()) |
janishorsts
reviewed
May 12, 2026
| RUN test -f /the-prescript-was-run | ||
| END | ||
|
|
||
| # Cache bust for CI |
Collaborator
There was a problem hiding this comment.
What is this comment for?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace cryptic 'unlazy force execution: failed to load LLB: security.insecure is not allowed' error with clear, user-friendly message.
Changes:
cmd/earthly/app/run.go: Create clear error message with 3 solution options
logbus/formatter/formatter.go: Print help message for build failures
tests/with-docker/Earthfile: Add simple test target for privileged tests
tests/Earthfile: Add comprehensive tests for all privileged operations
Before:
Error: build target: build main: failed to solve: unlazy force execution:
failed to load LLB: security.insecure is not allowed
Help: earth --allow-privileged (earth -P) flag is required
After:
Error: This build uses privileged operations which requires privileged mode.
Help: To fix this, use one of the following:
• Run with the -P flag: earthly -P +your-target • Set environment variable: export EARTHLY_ALLOW_PRIVILEGED=true • Add to config: earthly config global.allow_privileged true
Fixes #326