Skip to content

Conversation

@jchen293
Copy link
Contributor

Description

  • Adds new shipment.recommendShipDate, smartrate.recommendShipDate, and smartrate.estimateDeliveryDate functions

Testing

Add new unit tests

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@jchen293 jchen293 requested a review from a team July 11, 2024 21:52
Copy link
Member

@Justintime50 Justintime50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: nice work, this is a really clean PR!

@jchen293 jchen293 merged commit be13826 into master Jul 12, 2024
@jchen293 jchen293 deleted the smartrate_functions branch July 12, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants