A0c_AccessoryGenome.m rename recipsize -> dictsize#8
Open
ACCakut wants to merge 1 commit intoEasybel:mainfrom
Open
A0c_AccessoryGenome.m rename recipsize -> dictsize#8ACCakut wants to merge 1 commit intoEasybel:mainfrom
ACCakut wants to merge 1 commit intoEasybel:mainfrom
Conversation
Since “recipient” is not unambiguous, it should be replaced with a more precise naming, like “dict”. Depending on whether one generates accessory genome for A1_SNP2CNP or A4_Cov2Ins, the dictionary is either from donor or recipient strain, so that the old name is quite misleading. +1 for this PR from MF ;-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since “recipient” is not unambiguous, it should be replaced with a more precise naming, like “dict”.
Depending on whether one generates accessory genome for A1_SNP2CNP or A4_Cov2Ins, the dictionary is either from donor or recipient strain, so that the old name is quite misleading.
+1 for this PR from MF ;-)