chore: GitHub Actions を commit SHA でピン留め#3
Conversation
- `.github/workflows/*.yml` の全 `uses:` を `@<40文字 SHA> # vX.Y.Z` 形式に変換 (pinact 3.9.0 で自動生成) - Dependabot に `github-actions` / `nuget` エコシステムを追加し、 SHA ピン留め後も週次で自動アップデートされるようにする Supply-chain 対策として、サードパーティ Actions のミュータブルなタグ参照を 不変の commit SHA に固定する。
📝 WalkthroughWalkthrough新しいDependabotコンフィギュレーションファイルを追加し、GitHubアクションズとNuGetパッケージの自動依存性更新を有効化しました。また、CI/CDワークフローを更新して、GitHubアクションズへの参照をバージョンタグから特定のコミットSHAに変更しました。 Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/dependabot.yml (1)
35-36: オプション:allowセクションは省略可能です。
dependency-type: "all"は Dependabot のデフォルト動作なため、このallowセクションは技術的には不要です。ただし、明示的に記述することで意図が明確になるため、現状のままでも問題ありません。♻️ 簡略化する場合の提案
commit-message: prefix: "chore" include: "scope" - allow: - - dependency-type: "all"🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/dependabot.yml around lines 35 - 36, The allow block specifying dependency-type: "all" is redundant because Dependabot defaults to all dependency types; remove the allow section (the allow key and its dependency-type entry) from .github/dependabot.yml to simplify the config, or if you prefer explicitness, leave it as-is—locate the allow key and the dependency-type: "all" entry and delete them to implement the simplification.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.github/dependabot.yml:
- Around line 35-36: The allow block specifying dependency-type: "all" is
redundant because Dependabot defaults to all dependency types; remove the allow
section (the allow key and its dependency-type entry) from
.github/dependabot.yml to simplify the config, or if you prefer explicitness,
leave it as-is—locate the allow key and the dependency-type: "all" entry and
delete them to implement the simplification.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 7bf500a1-6231-456d-be05-7d46a211c8b8
📒 Files selected for processing (3)
.github/dependabot.yml.github/workflows/ci.yml.github/workflows/publish-nuget.yml
There was a problem hiding this comment.
Code Review
This pull request introduces a .github/dependabot.yml configuration to automate dependency updates for GitHub Actions and .NET NuGet packages on a weekly schedule. The feedback suggests grouping official GitHub Actions to minimize pull request noise and improve maintainability.
| - package-ecosystem: "github-actions" | ||
| directory: "/" | ||
| schedule: | ||
| interval: "weekly" | ||
| day: "monday" | ||
| time: "09:00" | ||
| timezone: "Asia/Tokyo" | ||
| open-pull-requests-limit: 5 | ||
| labels: | ||
| - "dependencies" | ||
| - "github-actions" | ||
| commit-message: | ||
| prefix: "chore" | ||
| include: "scope" |
There was a problem hiding this comment.
GitHub Actions の更新について、actions/* などの公式アクションをグループ化することをお勧めします。これにより、複数のアクションが同時に更新された際の PR ノイズを減らすことができます。
- package-ecosystem: "github-actions"
directory: "/"
schedule:
interval: "weekly"
day: "monday"
time: "09:00"
timezone: "Asia/Tokyo"
open-pull-requests-limit: 5
labels:
- "dependencies"
- "github-actions"
commit-message:
prefix: "chore"
include: "scope"
groups:
github-actions:
patterns:
- "actions/*"
概要
supply-chain 対策として、すべての GitHub Actions を mutable なタグ参照から不変の commit SHA 参照に切り替えます。あわせて Dependabot 設定を追加し、ピン留め後も継続的にアップデートされる運用にします。
変更内容
.github/workflows/ci.yml/publish-nuget.ymlのuses:をowner/repo@<40文字SHA> # vX.Y.Z形式に変換(pinact 3.9.0 で自動生成).github/dependabot.ymlを新規作成github-actions: 月曜 09:00 JST / PR 上限 5nuget: 火曜 09:00 JST / PR 上限 10動機
@v4等)は mutable で、Action 作者アカウント侵害時に@v4が差し替えられた場合、次回 CI 実行時に汚染コードが取り込まれる# vX.Y.Z)は Dependabot が SHA 自動更新する際の識別子として必要動作確認
関連
EcAuth organization 配下のほかのリポジトリ(EcAuth / EcAuth.MockIdP / ecauth-infrastructure / ecauth-website / ecauth-auth-js)でも同一方針で順次対応します。
🤖 Generated with Claude Code
Summary by CodeRabbit
リリースノート