Skip to content

Show ≤ and ≥ instead of <= and >= in UI#22

Merged
jhbengtsson merged 8 commits intomainfrom
ValidateChangeQueryText
Oct 5, 2022
Merged

Show ≤ and ≥ instead of <= and >= in UI#22
jhbengtsson merged 8 commits intomainfrom
ValidateChangeQueryText

Conversation

@EmilieSonne
Copy link
Copy Markdown

@EmilieSonne EmilieSonne commented Sep 22, 2022

Closes #12

@jhbengtsson jhbengtsson marked this pull request as ready for review September 29, 2022 11:17
@jhbengtsson jhbengtsson linked an issue Sep 30, 2022 that may be closed by this pull request
4 tasks
APaludan
APaludan previously approved these changes Sep 30, 2022
Comment thread src/main/java/ecdar/controllers/QueryController.java Outdated
Comment thread src/main/java/ecdar/controllers/QueryController.java Outdated
Comment thread src/main/java/ecdar/presentations/QueryPresentation.java Outdated
@mads256h
Copy link
Copy Markdown
Member

mads256h commented Oct 3, 2022

Also please change the title to better reflect the changes you have made. It would be even better if you wrote a short description.

@APaludan APaludan changed the title Validate change query text Show ≤ instead of <= in UI Oct 3, 2022
@APaludan APaludan changed the title Show ≤ instead of <= in UI Show ≤ and ≥ instead of <= and >= in UI Oct 3, 2022
Copy link
Copy Markdown
Member

@mads256h mads256h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lav en fælles funktion som bliver brugt alle de her steder:

Comment thread src/main/java/ecdar/abstractions/Query.java Outdated
Comment thread src/main/java/ecdar/controllers/QueryController.java Outdated
Comment thread src/main/java/ecdar/presentations/QueryPresentation.java Outdated
…-> sorry man kunne godt lave en static metode
Copy link
Copy Markdown
Member

@mads256h mads256h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

@jhbengtsson jhbengtsson merged commit 2adb417 into main Oct 5, 2022
@jhbengtsson jhbengtsson deleted the ValidateChangeQueryText branch October 5, 2022 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Autocorrect the symbol for refinement (>= to ≥)

5 participants