Reachability step 1: send request from simulation view#82
Merged
jhbengtsson merged 11 commits intomainfrom Nov 28, 2022
Merged
Conversation
EmilieSonne
changed the title
2 tasks
…s-toast Show reachability response as toast
Darkros1245
reviewed
Nov 24, 2022
S3JER
requested changes
Nov 25, 2022
S3JER
left a comment
S3JER
left a comment
There was a problem hiding this comment.
Check lige mine kommentar, der mangler lidt dokumentation.
Puvikaran2001
requested changes
Nov 25, 2022
Comment on lines
+95
to
+111
| private static String getSimulationQueryString() { | ||
| var stringBuilder = new StringBuilder(); | ||
|
|
||
| var appendComponentWithSeparator = false; | ||
| for (var componentName:ListOfComponents) { | ||
| if (appendComponentWithSeparator){ | ||
| stringBuilder.append("||" + componentName); | ||
| } | ||
| else { | ||
| stringBuilder.append(componentName); | ||
| } | ||
| if (!appendComponentWithSeparator) { | ||
| appendComponentWithSeparator = true; | ||
| } | ||
| } | ||
| return stringBuilder.toString(); | ||
| } |
There was a problem hiding this comment.
Tager I kun højde for parallel composition af to component?
Hvad med conjunction og quotient?
There was a problem hiding this comment.
Ja, det er kun den der fremgår af den grammatik, I sendte til os, og vi kan også kun lave simulation på parallel compositions lige nu. Eller har vi overset noget? :)
There was a problem hiding this comment.
Altså, det fungere også både for conjunction og quotient, men hvis I ikke kommer til at lave det, kan i bare resolve denne conversation
S3JER
approved these changes
Nov 28, 2022
Puvikaran2001
approved these changes
Nov 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #89, #76.
Clocks and request from other state than initial will come in a later PR (hence the TODOs to mark, where changes are still needed).
Result (yes/no) is shown in pop-up in the bottom of the view. If the state is not reachable, the backend doesn't return anything at all, so at timeout, a pop-up in the bottom of the view states that the query fail, which might be due to the state not being reachable. Highlight of path comes in later version (not part of this PR).