Merged
Conversation
Nielswps
pushed a commit
to Nielswps/Ecdar-GUI
that referenced
this pull request
Jan 20, 2023
* added declerations to sim view * clock names added + formatting * e * b * n * no height limit for trace element * clicking on trace doesnt delete following entries * padding * lillebitte ændring * refactor * Update SimulationHandler.java * added declerations to sim view (Ecdar#110) * omskrevet et forloop haha (Ecdar#115) * omskrevet et forloop haha * Update src/main/java/ecdar/controllers/SimulatorOverviewController.java Co-authored-by: Sigurd00 <j.skadborg00@gmail.com> Co-authored-by: Sigurd00 <j.skadborg00@gmail.com> * See previous sim states without deleting current trace (Ecdar#117) * clicking on trace doesnt delete following entries * lillebitte ændring * refactor * Update SimulationHandler.java * 102 clock values/constraints in trace (Ecdar#118) * clock names added + formatting * e * b * n * no height limit for trace element * padding Co-authored-by: WassawRoki <56611129+WassawRoki@users.noreply.github.com> * 92 reachability request kan sendes fra current state new (Ecdar#116) * iteration 1, does not take clocks into consideration * rette method description (relateret til tidligere issue dog) Co-authored-by: Emilie Steinmann <est@ampler.io> Co-authored-by: EmilieSonne <82802471+EmilieSonne@users.noreply.github.com> * 99 reachability show response on components (Ecdar#114) * metode til at highlight edges fra reachability response - virker ikke helt, men noget virker lidt :)) * hov weird replace og en irriterende rød link ting :) * dokumentation og oprydning * unhighlight edges before highlighting the edges from reachability response Co-authored-by: EmilieSonne <82802471+EmilieSonne@users.noreply.github.com> * ComponentsInSimulation (altså "ListOfComponents" renamet) is now plac… (Ecdar#108) * ComponentsInSimulation (altså "ListOfComponents" renamet) is now placed in SimulationHandler (and not static anymore) * Property "simulationQuery" moved to SimulationHandler and made non-static Co-authored-by: Emilie Steinmann <est@ampler.io> Co-authored-by: EmilieSonne <82802471+EmilieSonne@users.noreply.github.com> * rettelser * Solves issue 97 ish * rename getter * use local var instead of Ecdar.getSimulationHandler() all the time (Ecdar#127) * use local var instead of Ecdar.getSimulationHandler() all the time * fixed reachability tests * Checks for amount of commas instead of underscores Co-authored-by: Dolmer1 <mdolme20@student.aau.dk> * highlight reachability path with purple (Ecdar#131) * slettet en masse (Ecdar#129) * test (Ecdar#130) Co-authored-by: EmilieSonne <82802471+EmilieSonne@users.noreply.github.com> * Move initialization of simulationHandler to be first thing * Update UiSwitcherTest.java * slettet en udkommenteret liste * rettet i deserialize Co-authored-by: APaludan <andreashp@outlook.com> Co-authored-by: WassawRoki <56611129+WassawRoki@users.noreply.github.com> Co-authored-by: Julie H. Bengtsson <82820935+jhbengtsson@users.noreply.github.com> Co-authored-by: Sigurd00 <j.skadborg00@gmail.com> Co-authored-by: jhbengtsson <felsdp00@gmail.com> Co-authored-by: Dolmer1 <mdolme20@student.aau.dk>
seblund
reviewed
Feb 1, 2023
Member
seblund
left a comment
seblund
left a comment
There was a problem hiding this comment.
I'm not super familiar with the GUI code base but I went through the changes and they look good to me.
Generally I was a little uncertain as to when Ecdar.CANVAS_PADDING should be used instead of constants as I think the named constants should be preferred for readability. I've made comments where I would think that either the canvas padding or a new constant variable should be used. You can just let me know where it doesn't make sense :)
| @Override | ||
| public ObservableValue<? extends Number> getEdgeY() { | ||
| return new SimpleDoubleProperty(Grid.TOOL_BAR_HEIGHT + 2 * Grid.GRID_SIZE - 4d); | ||
| return new SimpleDoubleProperty(Ecdar.CANVAS_PADDING * 4 - 4d); |
Member
There was a problem hiding this comment.
Are we sure we don't want to keep variables for the toolbar height (TOOL_BAR_HEIGHT) and corner size (CORNER_SIZE). It seems like they were used often before and now they are replaced by magical constants, are they no longer useful without the grid?
Nielswps
added a commit
that referenced
this pull request
Sep 24, 2023
* WIP: Merging Ecdar 2.2 simulator into main * WIP: Compiling system with functionalities from Main working (simulator still not working, but presentation can be displayed) * WIP: Design updated for simulator and side panes logic/naming updated to account for having either the editor or the simulator view active * WIP: ProtoBuf messages updated and implementation of these into the GUI started * Minor clean up * WIP: Spacing for trace and transition headers added * WIP: BackendDriver usage for simulation started * WIP: Components can be shown within the simulator * ProtoBuf messages updated and no longer used messages commented out of implementation * TestFX added and protos updated * JUnit5 upgrade * Comment updated in preparation for query implementation in simulator view * WIP: Toggle for GUI mode added (sizing of toggle not working) * WIP: Dialog for initializing simulation added * Show tooltip when query was unsuccessful * replacement af >= <= med deres unicode * Modify getter of query, such that it complies with the backend expected format * Refinement symbol replaced with unicode in dropdown * fix typo * unittest af getQuery(); * changeRefinementSymbols added to display >= and <= correctly * refactoring * ikke længere i en funktion men direkte i changelistener * to static metoder på query.java til at replace refinement og unicode -> sorry man kunne godt lave en static metode * Update QueryPresentation.fxml * center query icons * When ENTER is pressed, we check if a query type has been selected before running query. * Simulator (#35) Fundament fra Niels * WIP: ''Fix'' to allow for compilation * align with condition for disabling action button * Hide generated component tab if there are no generated components (#31) * Nail location on all zoom levels not working FIXED * Print statement removed * if statement der sætter visible til true eller false * Arrows changed * forkortet Co-authored-by: Niels Vistisen <nielswps@gmail.com> Co-authored-by: Niels F. S. Vistisen <42961494+Nielswps@users.noreply.github.com> Co-authored-by: Dolmer1 <mdolme20@student.aau.dk> * first try * Update .gitmodules * send query requests with new grpc protocol * more work on grpc protocol * The popup will no longer be place outside the window * more simulation work * Update QueryPresentation.java * Moved SimulationHandler * getComponentsInfoBuilder changed to require string instead of query to generalize usage * We might have it * Clena up * WIP - Consume state in failing query * review fixes * initialize sim * det virker en lille smule nu * Update SimulationHandler.java * Now sets failing location for all locations in the response * Variante, nickname sign replacenment <= >= :) * Re-replace unicode to <= and >= before serializing * Replace Signes to guard fields W * lav static class to refactor code (using two methods only) * Use StringHelper for queries * Refacorizing Guard/Invarient code Yes * Ooops! * StringHelperTest * Parameterized test * Parameterized test af convert unicode to symbol * minor fixes for PR * Deleted * Make parameterized tests run with gradle - Import Junit parameterized tests - Remove TestRunner - Merge StringHelper tests into one file. * Paint locations red on failure response. Co-authored-by: Victor Doré Hansen <VictorDore@users.noreply.github.co> * Reset color and failing state on new query. Co-authored-by: Victor Doré Hanse <VictorDore@users.noreply.github.com> * displays failure message, still needs component name * Fixed java.util.ConcurrentModificationException thrown when removing failing locations * Modified build.gradle, fixes java.lang.illegalAccessError * Revert "Modified build.gradle, fixes java.lang.illegalAccessError" This reverts commit 02e6422 additions will be added on another branch. * Remove unused imports and fields * QueryPanel Checkmark enabled in View Dropdown * Documentation for public methods * Change get for each response * Initial work on painting failing actions Co-authored-by: Victor Doré Hanse <VictorDore@users.noreply.github.com> Co-authored-by: seba6505 <seba6505@users.noreply.github.com> * Refactor observer so it is added in the edge presentation. Co-authored-by: Victor DoréHansen <VictorDore@users.noreply.github.com> Co-authored-by: seba6505 <seba6505@users.noreply.github.com> * Red replaced by Lime in enabled colors * Set color back to component color when action doesnt fail. Other cleanup * Fix comment * cloning * bingbong * Consume correct response * Keep red color when selecting nails. Keep red color when swapping components * fix build error * fix test * fix test fr * PR changes * Update .gitmodules * maybe github checks works now? * deleted variable that is never used * Update build.yml * Update SimulationTest.java * remove unused imports * edit comment * small changes after merge * Update submodule * Implemented specific component in consumer * fixed * Update Component.java * Update SimulatorController.java * Remove unused imports * It works * Change build.gradle file. Surely it works now (#66) * reachability check på én location i sim med flere components. mangler clocks og anden startstate end initial. * et lille skriv * Added fields for signaturearrow I/O * showtoast based in reachability response status * panting faling inputs based on label * fixed error * test and refactoring of getLocationReachableQuery, and some minor changes * showtoast messages changed * renamed variable * Improve readability * ændret så vi ikke konverterer til string men bruger metoden til at se success * docs * docs * slette nogle ting * Updated QueryHandler to handle new gRPC values * Reachability: send request with startSimulation query as input (#104) * Save simulation query and use it for reachability check * remove unnecessary code * update tests to be independent of simulation start query format * Simulation logic (#81) * sim work + unique edge ids + temporary fix for scaling issues on startup * clean up * fix errors when switching back to editor * mostly refactoring - move highlight listeners to overviewcontroller - save state (to be used for the next steprequest) in SimulationState * reset when user selects another composition * Update SimulationHandler.java * Remove test data and show message to user when no available transitions * move simhandler * clean up + comments * add functionality to reset button * Update Edge.java * Update SimulatorController.java * Remove unused imports * comment + rename method * fixed edge id error when cloning for sim + comments * footer disabled * bingbong * Update EcdarPresentation.fxml * Yeeeet! * Update SimulatorController.java * rename refreshTransitions * Update SimulationState.java * jep * fix for when SpecificComponent is null in sim response * Update TransitionPaneElementPresentation.fxml * only change to hand cursor on available transitions Co-authored-by: APaludan <andreashp@outlook.com> Co-authored-by: WassawRoki <56611129+WassawRoki@users.noreply.github.com> * somehow works * update handleQueryResponse to support new protos * added a radio button connected sh: wq: command not found * fixed a mistake for default j-ecdar * Made the multithreading work * renamed a parameter * Added a failed IO strings to component, and match them with the current IO strings for the component * Update QueryHandler.java * Fixed for new main and proto * works when clock reduction is disabledisaebeld * Made coloring consistent across components, added checks for only failing components * Added check for specific components * så vi ikke glemmer den :) * Update src/main/java/ecdar/backend/QueryHandler.java * changed radiobutton to be a checkbox instead * Combined branch (#124) * added declerations to sim view * clock names added + formatting * e * b * n * no height limit for trace element * clicking on trace doesnt delete following entries * padding * lillebitte ændring * refactor * Update SimulationHandler.java * added declerations to sim view (#110) * omskrevet et forloop haha (#115) * omskrevet et forloop haha * Update src/main/java/ecdar/controllers/SimulatorOverviewController.java Co-authored-by: Sigurd00 <j.skadborg00@gmail.com> Co-authored-by: Sigurd00 <j.skadborg00@gmail.com> * See previous sim states without deleting current trace (#117) * clicking on trace doesnt delete following entries * lillebitte ændring * refactor * Update SimulationHandler.java * 102 clock values/constraints in trace (#118) * clock names added + formatting * e * b * n * no height limit for trace element * padding Co-authored-by: WassawRoki <56611129+WassawRoki@users.noreply.github.com> * 92 reachability request kan sendes fra current state new (#116) * iteration 1, does not take clocks into consideration * rette method description (relateret til tidligere issue dog) Co-authored-by: Emilie Steinmann <est@ampler.io> Co-authored-by: EmilieSonne <82802471+EmilieSonne@users.noreply.github.com> * 99 reachability show response on components (#114) * metode til at highlight edges fra reachability response - virker ikke helt, men noget virker lidt :)) * hov weird replace og en irriterende rød link ting :) * dokumentation og oprydning * unhighlight edges before highlighting the edges from reachability response Co-authored-by: EmilieSonne <82802471+EmilieSonne@users.noreply.github.com> * ComponentsInSimulation (altså "ListOfComponents" renamet) is now plac… (#108) * ComponentsInSimulation (altså "ListOfComponents" renamet) is now placed in SimulationHandler (and not static anymore) * Property "simulationQuery" moved to SimulationHandler and made non-static Co-authored-by: Emilie Steinmann <est@ampler.io> Co-authored-by: EmilieSonne <82802471+EmilieSonne@users.noreply.github.com> * rettelser * Solves issue 97 ish * rename getter * use local var instead of Ecdar.getSimulationHandler() all the time (#127) * use local var instead of Ecdar.getSimulationHandler() all the time * fixed reachability tests * Checks for amount of commas instead of underscores Co-authored-by: Dolmer1 <mdolme20@student.aau.dk> * highlight reachability path with purple (#131) * slettet en masse (#129) * test (#130) Co-authored-by: EmilieSonne <82802471+EmilieSonne@users.noreply.github.com> * Move initialization of simulationHandler to be first thing * Update UiSwitcherTest.java * slettet en udkommenteret liste * rettet i deserialize Co-authored-by: APaludan <andreashp@outlook.com> Co-authored-by: WassawRoki <56611129+WassawRoki@users.noreply.github.com> Co-authored-by: Julie H. Bengtsson <82820935+jhbengtsson@users.noreply.github.com> Co-authored-by: Sigurd00 <j.skadborg00@gmail.com> Co-authored-by: jhbengtsson <felsdp00@gmail.com> Co-authored-by: Dolmer1 <mdolme20@student.aau.dk> * Proto commit update * WIP: Moved BackendInstance * WIP: Issue with having to double press components to update active model FIXED * Clean-up based on PR walkthrough * Missing test dependency FIXED * Merge issues FIXED * Merge of simulator and main (#17) * Fix so new connections are added as backend connections after they are 'ready' New connections are added to the backend connections here: https://github.com/Ecdar/Ecdar-GUI/blob/9ca653b7817706f132d88c8a773a0487e99c6038/src/main/java/ecdar/backend/BackendDriver.java#L153 But that is before the `updateComponents` query has completed, so a query can take the backend before it is ready. This results in a bunch of non-deterministic errors when executing queries, one being the `UNAVAILABLE: io exception` error. The backend should only be added on the `onCompleted` as is already done: https://github.com/Ecdar/Ecdar-GUI/blob/9ca653b7817706f132d88c8a773a0487e99c6038/src/main/java/ecdar/backend/BackendDriver.java#L171 After this small fix you can spam queries to your heart's content with no issues :) * Fix to prevent no default backend existing (#130) * `README.md` Update (#128) * WIP: ECDAR reference added, dependency section updated, and spelling fixed * WIP: Backend replaced with Engine to be consistent with naming * WIP: Engine Configuration enriched * Contributing section added and code snippets updated to be executable on Linux * Files reverted to main version * Added files removed (added through #131) * WIP: Code Organization section added * Utility and Miscellaneous sub sections added to Code Organisation * Walkthrough changes * Component Refactor (#126) * WIP: ComponentController/Presentation REFACTORED * Location placement logic extracted to separate class * Cleanup and minor refactoring * WIP: GlobalDeclarations refactored * Reachability analysis exception FIXED * WIP: Removed most of the static dependencies in component * LocationPlacer test failing * WIP: Component refactor (other elements have been refactored as a side-effect) * WIP: Verification aspects moved out of component into new class in mutation package * WIP: Location placement from dropdown FIXED * WIP: Refactoring and testing of ComponentVerificationTransformer started * WIP: LocationPlacer generalized and tested, and unnecessary initial and final location checks removed * WIP: LocationPlacer renamed to UnoccupiedSpaceFinder and offset add as parameter * Personal walkthrough changes * Universal and inconsistent location naming approach refactored * Color refactoring and initial location color fix * Walkthrough changes * Dangling engines FIX (#140) * WIP: Potential fix for dangling engines by keeping track of started connections in one place and removing this responsibility from the QueryHandler * Method rename to better follow new logic * Add started backend connections immediately and use them to find used ports --------- Co-authored-by: Sebastian Lund <sebastianlund112@gmail.com> * Removed the contains deadlock option from the context menu in ComponentController (#139) * Query types updated to follow theory (#143) * Query types updated to follow theory * Updated bisim_minim name * Fix typo --------- Co-authored-by: Sebastian Lund <sebastianlund112@gmail.com> * Declaration alignment FIX (#137) * Declaration resizing and alignment fixed for both single and split canvas (and minor refactoring) * Zoom keyboard shortcuts on split canvas FIXED * NullPointerException when opening existing project FIXED * WIP: Exceptions are thrown on project open and split canvas * WIP: Exceptions FIXED (Refactoring might be needed before merge) * Review suggestions * Dangling engines FIX (#140) * WIP: Potential fix for dangling engines by keeping track of started connections in one place and removing this responsibility from the QueryHandler * Method rename to better follow new logic * Add started backend connections immediately and use them to find used ports --------- Co-authored-by: Sebastian Lund <sebastianlund112@gmail.com> * Declaration resizing and alignment fixed for both single and split canvas (and minor refactoring) * Zoom keyboard shortcuts on split canvas FIXED * NullPointerException when opening existing project FIXED * WIP: Exceptions are thrown on project open and split canvas * WIP: Exceptions FIXED (Refactoring might be needed before merge) * Review suggestions --------- Co-authored-by: Sebastian Lund <sebastianlund112@gmail.com> * Backend to engine (#136) * WIP: ECDAR reference added, dependency section updated, and spelling fixed * WIP: Backend replaced with Engine to be consistent with naming * WIP: Engine Configuration enriched * Contributing section added and code snippets updated to be executable on Linux * Rename branched out from readme_update * File used on other branch * WIP: ECDAR reference added, dependency section updated, and spelling fixed * WIP: Backend replaced with Engine to be consistent with naming * Contributing section added and code snippets updated to be executable on Linux * File used on other branch * WIP: Backend replaced with Engine to be consistent with naming * WIP: Engine Configuration enriched * File used on other branch * Line about the deprecated mutation package added * Update src/main/java/ecdar/abstractions/Query.java Co-authored-by: Andreas K. Brandhøj <akbr18@student.aau.dk> * WIP: Review changes (part 1/2) * Update src/main/java/ecdar/backend/BackendHelper.java Co-authored-by: Andreas K. Brandhøj <akbr18@student.aau.dk> * WIP: Review changes (part 2/2) * startedEngineConnections filtering added to only account for ports of the related engine and comment updated * Found some more strings and vars to update * Review suggestions implemented --------- Co-authored-by: Andreas K. Brandhøj <akbr18@student.aau.dk> * Backend refactor (#147) * WIP: ECDAR reference added, dependency section updated, and spelling fixed * WIP: Backend replaced with Engine to be consistent with naming * WIP: Engine Configuration enriched * Contributing section added and code snippets updated to be executable on Linux * Rename branched out from readme_update * File used on other branch * WIP: ECDAR reference added, dependency section updated, and spelling fixed * WIP: Backend replaced with Engine to be consistent with naming * Contributing section added and code snippets updated to be executable on Linux * File used on other branch * WIP: Backend replaced with Engine to be consistent with naming * WIP: Engine Configuration enriched * File used on other branch * Line about the deprecated mutation package added * Update src/main/java/ecdar/abstractions/Query.java Co-authored-by: Andreas K. Brandhøj <akbr18@student.aau.dk> * WIP: Review changes (part 1/2) * Update src/main/java/ecdar/backend/BackendHelper.java Co-authored-by: Andreas K. Brandhøj <akbr18@student.aau.dk> * WIP: refactoring started * WIP: Review changes (part 2/2) * BackendDriver refactored to be more readable (method division) * More refactoring * WIP: Backend replaced with Engine to be consistent with naming * File used on other branch * WIP: Backend replaced with Engine to be consistent with naming * File used on other branch * BackendDriver refactored to be more readable (method division) * More refactoring * Ensure successful rebase and merge (#16) * Backend to engine (#136) * WIP: ECDAR reference added, dependency section updated, and spelling fixed * WIP: Backend replaced with Engine to be consistent with naming * WIP: Engine Configuration enriched * Contributing section added and code snippets updated to be executable on Linux * Rename branched out from readme_update * File used on other branch * WIP: ECDAR reference added, dependency section updated, and spelling fixed * WIP: Backend replaced with Engine to be consistent with naming * Contributing section added and code snippets updated to be executable on Linux * File used on other branch * WIP: Backend replaced with Engine to be consistent with naming * WIP: Engine Configuration enriched * File used on other branch * Line about the deprecated mutation package added * Update src/main/java/ecdar/abstractions/Query.java Co-authored-by: Andreas K. Brandhøj <akbr18@student.aau.dk> * WIP: Review changes (part 1/2) * Update src/main/java/ecdar/backend/BackendHelper.java Co-authored-by: Andreas K. Brandhøj <akbr18@student.aau.dk> * WIP: Review changes (part 2/2) * startedEngineConnections filtering added to only account for ports of the related engine and comment updated * Found some more strings and vars to update * Review suggestions implemented --------- Co-authored-by: Andreas K. Brandhøj <akbr18@student.aau.dk> * WIP: Backend replaced with Engine to be consistent with naming * File used on other branch * WIP: Backend replaced with Engine to be consistent with naming * File used on other branch * BackendDriver refactored to be more readable (method division) * More refactoring --------- Co-authored-by: Andreas K. Brandhøj <akbr18@student.aau.dk> * Minor naming and comment errors fixed * WIP: Exception handling added (not done) to engine handling * WIP: Comment removed * Engine process and connection exception handling finished * Final backend refactor * Review renaming implemented * Get IP added to Engine for better interface * EngineConnection initialization moved to separate class * ToDo's removed and added as issues on the repo * ToDo's removed and added as issues on the repo v2 * Shutdown of the application updated for better handling --------- Co-authored-by: Andreas K. Brandhøj <akbr18@student.aau.dk> * Community Standards (#151) * Contributing file, issue templates added, and mistakenly removed image reintroduced * feature label replaced with enhancement * PR template added and CONTRIBUTING.md moved to hidden github directory * PR template reformattet * CODE_OF_CONDUCT.md added * PR template rewording * Bug report template updated and link to Contributing added to readme * Updated JDK example * WIP: Ongoing merge effort (not compiling) * WIP: Compiles (simulator not working) * WIP: Sketchy engine communication for simulation functionality to ensure compatibility (WORKING) * Red color on locations updated --------- Co-authored-by: Sebastian Lund <sebastianlund112@gmail.com> Co-authored-by: Morten Hartvigsen <morten@polytope.dk> Co-authored-by: Andreas K. Brandhøj <akbr18@student.aau.dk> * WIP: QueryPane resizing refresh increased * Refactoring * WIP: Simulation RPC requests moved to Engine to utilize connection pool * ToDos cleaned up * Default engine loading FIX (#153) * Engine access modifiers updated and loading of default status of engines FIXED * Unused default_engine preference variable removed * Feature/visitor pattern (#20) * Visitor pattern implemented for gRPC request construction * New proto (#19) * WIP: Update to new protobuf * WIP: Updated proto to futureproof1 branch an moved simulation classes to separate package * WIP: Compilable * WIP: Full refactor/re-implementation started * WIP: Complete refactor * WIP: Continued work to re-implement simulation with new proto * WIP: Initial simulation step FIXED for new proto * WIP: Simulation steps FIXED * WIP: Query test fixed and dublicate consumers merged * WIP: Minor clean up * WIP: Rough tracelog state design draft * WIP: Decision design draft implemented and refactoring * WIP: minWidth removed from right sim pane * Highlighting of simulation extracted into helper class * Decision edges highlighting ADDED and tracelog fading FIXED * Constraint formatting improved and combination logic initiated * WIP: Working clocke constraint merging and string generation * WIP: Decisions are now updated on preview, decoupling of protobuf from simulation abstractions, tracelog reversed, and clean-up * WIP: Unused import removed * Proto updated to use state-from-step and simulation test update to use locationTree (currenly failing) (#21) * WIP: Concrete sim delay REMOVED, restart sim confirm dialog ADDED, and several minor simulator issues FIXED * WIP: Unused state pane files REMOVED --------- Co-authored-by: APaludan <andreashp@outlook.com> Co-authored-by: jhbengtsson <felsdp00@gmail.com> Co-authored-by: Emilie Steinmann <est@ampler.io> Co-authored-by: Julie H. Bengtsson <82820935+jhbengtsson@users.noreply.github.com> Co-authored-by: WassawRoki <56611129+WassawRoki@users.noreply.github.com> Co-authored-by: Ibra4i <82802664+Ibra4i@users.noreply.github.com> Co-authored-by: Dolmer1 <mdolme20@student.aau.dk> Co-authored-by: Sigurd <j.skadborg00@gmail.com> Co-authored-by: Mads Mogensen <mail@madsmogensen.dk> Co-authored-by: Victor Doré Hansen <VictorDore@users.noreply.github.co> Co-authored-by: Victor Doré Hanse <VictorDore@users.noreply.github.com> Co-authored-by: martin <martin@mmortdebian.aau> Co-authored-by: Victor <vdha20@student.aau.dk> Co-authored-by: Victor Doré Hansen <74188341+VictorDore@users.noreply.github.com> Co-authored-by: seba6505 <seba6505@users.noreply.github.com> Co-authored-by: seba6505 <45783179+seba6505@users.noreply.github.com> Co-authored-by: Claes Berg Mortensen <claesm1999@gmail.com> Co-authored-by: Claes Berg Mortensen <45384716+HTHNLNDN@users.noreply.github.com> Co-authored-by: EmilieSonne <82802471+EmilieSonne@users.noreply.github.com> Co-authored-by: Casper-NS <caspernyvang@gmail.com> Co-authored-by: Casper-NS <37834568+Casper-NS@users.noreply.github.com> Co-authored-by: Sebastian Lund <sebastianlund112@gmail.com> Co-authored-by: Morten Hartvigsen <morten@polytope.dk> Co-authored-by: Andreas K. Brandhøj <akbr18@student.aau.dk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the Grid from the editor, lowering the amount of computations needed as well as the snapping of elements
Closes #105