Skip to content

Conversation

@paigewilliams
Copy link
Contributor

@paigewilliams paigewilliams commented Nov 20, 2025

asana task

While doing some QA I noticed that we were getting the error, clearInterval is not a function when trying to export the DB. Whoops!

Also addressing @rhodges comments on using HttpResponse in ExportDatabase.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses two issues found during QA: fixing a JavaScript error where clearInterval was being invoked immediately instead of being passed as a callback, and refactoring the ExportDatabase view to improve response handling. However, the Python changes introduce new bugs that need to be addressed.

Key Changes

  • Fixed JavaScript callback issue where clearInterval(checkStatus) was executed immediately instead of being passed as a function reference
  • Modified ExportDatabase response initialization and removed the fallback return statement
  • Cleaned up whitespace in both files

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
TEKDB/TEKDB/static/admin/js/admin_index.js Correctly wraps clearInterval call in arrow function to pass as callback instead of executing immediately
TEKDB/TEKDB/views.py Attempts to address HttpResponse usage but introduces bugs: assigns class instead of instance, and removes return statement without replacement

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@paigewilliams paigewilliams merged commit 27a7a7e into main Nov 21, 2025
2 checks passed
Copy link
Member

@rhodges rhodges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants