clear export_status cookie after response and set timeout if no response #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses an issue where the export_status cookie persisted after export operations, causing hanging export requests. The changes ensure proper cookie cleanup and add a timeout mechanism for export operations.
- Adds explicit
path=/parameter to allexport_statuscookie operations for consistent cookie handling - Implements a client-side cookie clearing function that runs after every export operation completes
- Introduces a 1-minute timeout for export operations with user-friendly error messaging
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| TEKDB/TEKDB/views.py | Adds explicit path=/ parameter to export_status cookie setting in both success and error cases |
| TEKDB/TEKDB/static/admin/js/admin_index.js | Implements cookie cleanup function, adds 1-minute timeout with polling logic refactoring, and improves error handling consolidation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
asana task
In doing some testing in demo.itkdb.org, I noticed that the
export_statuscookie was sticking around and leaving export requests hanging. This clears the cookie after the response, and also sets a 1 minute timeout for the request. We can adjust this number if 1 minute seems too short.